feat: Add mobile responsive layout, open room access, and admin room management
Mobile Responsive Layout: - Add useMediaQuery, useIsMobile, useIsTablet, useIsDesktop hooks for device detection - Create MobileHeader component with hamburger menu and action drawer - Create BottomToolbar for mobile navigation (Files, Members) - Create SlidePanel component for full-screen mobile sidebars - Update RoomDetail.tsx with mobile/desktop conditional rendering - Update RoomList.tsx with single-column grid and touch-friendly buttons - Add CSS custom properties for safe areas and touch targets (min 44px) - Add mobile viewport meta tags for notched devices Open Room Access: - All authenticated users can view all rooms (not just their own) - Users can join active rooms they're not members of - Add is_member field to room responses - Update room list API to return all rooms by default Admin Room Management: - Add permanent delete functionality for system admins - Add delete confirmation dialog with room title verification - Broadcast room deletion via WebSocket to connected users - Add users search API for adding members 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
This commit is contained in:
egg
@@ -5,6 +5,7 @@ FastAPI router with all room-related endpoints
|
||||
from fastapi import APIRouter, Depends, HTTPException, status, Query
|
||||
from sqlalchemy.orm import Session
|
||||
from typing import List, Optional
|
||||
from datetime import datetime
|
||||
|
||||
from app.core.database import get_db
|
||||
from app.modules.auth import get_current_user
|
||||
@@ -20,6 +21,7 @@ from app.modules.chat_room.dependencies import (
|
||||
require_admin,
|
||||
get_user_effective_role
|
||||
)
|
||||
from app.modules.realtime.websocket_manager import manager as ws_manager
|
||||
|
||||
router = APIRouter(prefix="/api/rooms", tags=["Chat Rooms"])
|
||||
|
||||
@@ -59,7 +61,8 @@ async def create_room(
|
||||
|
||||
return schemas.RoomResponse(
|
||||
**room.__dict__,
|
||||
current_user_role=role
|
||||
current_user_role=role,
|
||||
is_member=True # Creator is always a member
|
||||
)
|
||||
|
||||
|
||||
@@ -69,13 +72,18 @@ async def list_rooms(
|
||||
incident_type: Optional[schemas.IncidentType] = None,
|
||||
severity: Optional[schemas.SeverityLevel] = None,
|
||||
search: Optional[str] = None,
|
||||
all: bool = Query(False, description="Admin only: show all rooms"),
|
||||
my_rooms: bool = Query(False, description="Filter to show only rooms where user is a member"),
|
||||
limit: int = Query(20, ge=1, le=100),
|
||||
offset: int = Query(0, ge=0),
|
||||
db: Session = Depends(get_db),
|
||||
current_user: dict = Depends(get_current_user)
|
||||
):
|
||||
"""List rooms accessible to current user"""
|
||||
"""List all rooms for authenticated user
|
||||
|
||||
Returns all rooms by default. Use my_rooms=true to filter to only rooms
|
||||
where the current user is a member. Each room includes is_member and
|
||||
current_user_role fields.
|
||||
"""
|
||||
user_email = current_user["username"]
|
||||
is_admin = membership_service.is_system_admin(user_email)
|
||||
|
||||
@@ -85,21 +93,23 @@ async def list_rooms(
|
||||
incident_type=incident_type,
|
||||
severity=severity,
|
||||
search=search,
|
||||
all=all,
|
||||
my_rooms=my_rooms,
|
||||
limit=limit,
|
||||
offset=offset
|
||||
)
|
||||
|
||||
rooms, total = room_service.list_user_rooms(db, user_email, filters, is_admin)
|
||||
|
||||
# Add user role to each room
|
||||
# Add user role and membership status to each room
|
||||
room_responses = []
|
||||
for room in rooms:
|
||||
role = membership_service.get_user_role_in_room(db, room.room_id, user_email)
|
||||
is_member = role is not None
|
||||
room_response = schemas.RoomResponse(
|
||||
**room.__dict__,
|
||||
current_user_role=role,
|
||||
is_admin_view=is_admin and all
|
||||
is_member=is_member,
|
||||
is_admin_view=is_admin
|
||||
)
|
||||
room_responses.append(room_response)
|
||||
|
||||
@@ -125,11 +135,13 @@ async def get_room_details(
|
||||
member_responses = [schemas.MemberResponse.from_orm(m) for m in members]
|
||||
|
||||
is_admin = membership_service.is_system_admin(current_user["username"])
|
||||
is_member = role is not None
|
||||
|
||||
return schemas.RoomResponse(
|
||||
**room.__dict__,
|
||||
members=member_responses,
|
||||
current_user_role=role,
|
||||
is_member=is_member,
|
||||
is_admin_view=is_admin
|
||||
)
|
||||
|
||||
@@ -152,7 +164,7 @@ async def update_room(
|
||||
)
|
||||
|
||||
role = membership_service.get_user_role_in_room(db, room_id, current_user["username"])
|
||||
return schemas.RoomResponse(**room.__dict__, current_user_role=role)
|
||||
return schemas.RoomResponse(**room.__dict__, current_user_role=role, is_member=True)
|
||||
|
||||
except ValueError as e:
|
||||
raise HTTPException(
|
||||
@@ -178,6 +190,88 @@ async def delete_room(
|
||||
return schemas.SuccessResponse(message="Room archived successfully")
|
||||
|
||||
|
||||
@router.delete("/{room_id}/permanent", response_model=schemas.SuccessResponse)
|
||||
async def permanent_delete_room(
|
||||
room_id: str,
|
||||
_: None = Depends(require_admin),
|
||||
db: Session = Depends(get_db)
|
||||
):
|
||||
"""Permanently delete a room and all associated data (admin only)
|
||||
|
||||
This is an irreversible operation that deletes:
|
||||
- All room members
|
||||
- All messages and reactions
|
||||
- All uploaded files (including MinIO storage)
|
||||
- All generated reports (including MinIO storage)
|
||||
- The room itself
|
||||
|
||||
Only system administrators can perform this operation.
|
||||
"""
|
||||
# Broadcast room_deleted event to all connected users BEFORE deleting
|
||||
await ws_manager.broadcast_to_room(room_id, {
|
||||
"type": "system",
|
||||
"event": "room_deleted",
|
||||
"room_id": room_id,
|
||||
"timestamp": datetime.utcnow().isoformat()
|
||||
})
|
||||
|
||||
success, error = room_service.permanent_delete_room(db, room_id)
|
||||
|
||||
if not success:
|
||||
if error == "Room not found":
|
||||
raise HTTPException(
|
||||
status_code=status.HTTP_404_NOT_FOUND,
|
||||
detail="Room not found"
|
||||
)
|
||||
raise HTTPException(
|
||||
status_code=status.HTTP_500_INTERNAL_SERVER_ERROR,
|
||||
detail=f"Failed to delete room: {error}"
|
||||
)
|
||||
|
||||
return schemas.SuccessResponse(message="Room permanently deleted")
|
||||
|
||||
|
||||
# Self-Join Endpoint
|
||||
@router.post("/{room_id}/join", response_model=schemas.MemberResponse)
|
||||
async def join_room(
|
||||
room_id: str,
|
||||
db: Session = Depends(get_db),
|
||||
current_user: dict = Depends(get_current_user)
|
||||
):
|
||||
"""Self-join a room as a viewer
|
||||
|
||||
Any authenticated user can join any non-archived room.
|
||||
User will be added with VIEWER role.
|
||||
"""
|
||||
user_email = current_user["username"]
|
||||
|
||||
member, error_code, existing = membership_service.self_join_room(
|
||||
db, room_id, user_email
|
||||
)
|
||||
|
||||
if error_code == "room_not_found":
|
||||
raise HTTPException(
|
||||
status_code=status.HTTP_404_NOT_FOUND,
|
||||
detail="Room not found"
|
||||
)
|
||||
elif error_code == "room_archived":
|
||||
raise HTTPException(
|
||||
status_code=status.HTTP_400_BAD_REQUEST,
|
||||
detail="Cannot join archived room"
|
||||
)
|
||||
elif error_code == "already_member":
|
||||
raise HTTPException(
|
||||
status_code=status.HTTP_409_CONFLICT,
|
||||
detail={
|
||||
"message": "Already a member of this room",
|
||||
"current_role": existing.role.value,
|
||||
"added_at": existing.added_at.isoformat()
|
||||
}
|
||||
)
|
||||
|
||||
return schemas.MemberResponse.from_orm(member)
|
||||
|
||||
|
||||
# Membership Endpoints
|
||||
@router.get("/{room_id}/members", response_model=List[schemas.MemberResponse])
|
||||
async def list_room_members(
|
||||
@@ -224,10 +318,37 @@ async def update_member_role(
|
||||
room_id: str,
|
||||
user_id: str,
|
||||
request: schemas.UpdateMemberRoleRequest,
|
||||
_: None = Depends(validate_room_owner),
|
||||
db: Session = Depends(get_db)
|
||||
db: Session = Depends(get_db),
|
||||
current_user: dict = Depends(get_current_user)
|
||||
):
|
||||
"""Update a member's role"""
|
||||
"""Update a member's role
|
||||
|
||||
Permission rules:
|
||||
- OWNER can change any role
|
||||
- EDITOR can upgrade VIEWER → EDITOR only
|
||||
- EDITOR cannot downgrade, remove, or set OWNER role
|
||||
"""
|
||||
changer_id = current_user["username"]
|
||||
|
||||
# Get target member's current role
|
||||
current_role = membership_service.get_user_role_in_room(db, room_id, user_id)
|
||||
if not current_role:
|
||||
raise HTTPException(
|
||||
status_code=status.HTTP_404_NOT_FOUND,
|
||||
detail="Member not found"
|
||||
)
|
||||
|
||||
# Check permission
|
||||
allowed, error_msg = membership_service.can_change_member_role(
|
||||
db, room_id, changer_id, user_id, current_role, request.role
|
||||
)
|
||||
|
||||
if not allowed:
|
||||
raise HTTPException(
|
||||
status_code=status.HTTP_403_FORBIDDEN,
|
||||
detail=error_msg
|
||||
)
|
||||
|
||||
member = membership_service.update_member_role(
|
||||
db,
|
||||
room_id,
|
||||
@@ -251,23 +372,28 @@ async def update_member_role(
|
||||
async def remove_member(
|
||||
room_id: str,
|
||||
user_id: str,
|
||||
_: None = Depends(require_room_permission("manage_members")),
|
||||
db: Session = Depends(get_db),
|
||||
current_user: dict = Depends(get_current_user)
|
||||
):
|
||||
"""Remove a member from the room"""
|
||||
# Prevent removing the last owner
|
||||
if user_id == current_user["username"]:
|
||||
role = membership_service.get_user_role_in_room(db, room_id, user_id)
|
||||
if role == MemberRole.OWNER:
|
||||
# Check if there are other owners
|
||||
members = membership_service.get_room_members(db, room_id)
|
||||
owner_count = sum(1 for m in members if m.role == MemberRole.OWNER)
|
||||
if owner_count == 1:
|
||||
raise HTTPException(
|
||||
status_code=status.HTTP_400_BAD_REQUEST,
|
||||
detail="Cannot remove the last owner"
|
||||
)
|
||||
"""Remove a member from the room
|
||||
|
||||
Permission rules:
|
||||
- OWNER can remove any member
|
||||
- EDITOR cannot remove members (only owner can)
|
||||
- Users can remove themselves (leave room) unless they're the only owner
|
||||
"""
|
||||
remover_id = current_user["username"]
|
||||
|
||||
# Check permission
|
||||
allowed, error_msg = membership_service.can_remove_member(
|
||||
db, room_id, remover_id, user_id
|
||||
)
|
||||
|
||||
if not allowed:
|
||||
raise HTTPException(
|
||||
status_code=status.HTTP_403_FORBIDDEN,
|
||||
detail=error_msg
|
||||
)
|
||||
|
||||
success = membership_service.remove_member(db, room_id, user_id)
|
||||
if not success:
|
||||
|
||||
Reference in New Issue
Block a user