diff --git a/app/main.py b/app/main.py index 53aa8c7..3f8bff2 100644 --- a/app/main.py +++ b/app/main.py @@ -11,6 +11,7 @@ from fastapi.responses import FileResponse from app.core.config import get_settings from app.core.database import engine, Base from app.modules.auth import router as auth_router +from app.modules.auth.users_router import router as users_router from app.modules.auth.middleware import auth_middleware from app.modules.chat_room import router as chat_room_router from app.modules.chat_room.services.template_service import template_service @@ -43,12 +44,12 @@ app.add_middleware( allow_headers=["*"], ) -# Authentication middleware (applies to all routes except login/logout) -# Note: Commented out for now to allow testing without auth -# app.middleware("http")(auth_middleware) +# Authentication middleware (applies to all /api routes except login/logout) +app.middleware("http")(auth_middleware) # Include routers app.include_router(auth_router) +app.include_router(users_router) app.include_router(chat_room_router) app.include_router(realtime_router) app.include_router(file_storage_router) @@ -81,21 +82,14 @@ async def startup_event(): logger.warning(f"MinIO connection failed: {e} - file uploads will be unavailable") -@app.get("/") -async def root(): - """Health check endpoint""" - return { - "status": "ok", - "service": "Task Reporter API", - "version": "1.0.0", - "description": "生產線異常即時反應系統", - } - - -@app.get("/health") +@app.get("/api/health") async def health_check(): """Health check for monitoring""" - return {"status": "healthy"} + return { + "status": "healthy", + "service": "Task Reporter API", + "version": "1.0.0", + } # Serve frontend static files (only if build exists) diff --git a/app/modules/auth/middleware.py b/app/modules/auth/middleware.py index 402ddff..df38e96 100644 --- a/app/modules/auth/middleware.py +++ b/app/modules/auth/middleware.py @@ -6,7 +6,8 @@ 3. AD token 自動刷新(5 分鐘內過期時) 4. 重試計數器管理(最多 3 次) """ -from fastapi import Request, HTTPException, status +from fastapi import Request, status +from fastapi.responses import JSONResponse from datetime import datetime, timedelta from app.core.database import SessionLocal from app.core.config import get_settings @@ -25,15 +26,19 @@ class AuthMiddleware: async def __call__(self, request: Request, call_next): """Process request through authentication checks""" - # Skip auth for login/logout endpoints - if request.url.path in ["/api/auth/login", "/api/auth/logout", "/docs", "/openapi.json"]: + # Skip auth for non-API routes (frontend), login/logout, and docs + path = request.url.path + if not path.startswith("/api") or path in ["/api/auth/login", "/api/auth/logout", "/api/health"]: + return await call_next(request) + if path in ["/docs", "/openapi.json", "/redoc"]: return await call_next(request) # Extract token from Authorization header authorization = request.headers.get("Authorization") if not authorization or not authorization.startswith("Bearer "): - raise HTTPException( - status_code=status.HTTP_401_UNAUTHORIZED, detail="Authentication required" + return JSONResponse( + status_code=status.HTTP_401_UNAUTHORIZED, + content={"detail": "Authentication required"} ) internal_token = authorization.replace("Bearer ", "") @@ -44,32 +49,35 @@ class AuthMiddleware: # Query session user_session = session_service.get_session_by_token(db, internal_token) if not user_session: - raise HTTPException( - status_code=status.HTTP_401_UNAUTHORIZED, detail="Invalid or expired token" + return JSONResponse( + status_code=status.HTTP_401_UNAUTHORIZED, + content={"detail": "Invalid or expired token"} ) # Check 3-day inactivity timeout inactivity_limit = datetime.utcnow() - timedelta(days=settings.SESSION_INACTIVITY_DAYS) if user_session.last_activity < inactivity_limit: session_service.delete_session(db, user_session.id) - raise HTTPException( + return JSONResponse( status_code=status.HTTP_401_UNAUTHORIZED, - detail="Session expired due to inactivity. Please login again.", + content={"detail": "Session expired due to inactivity. Please login again."} ) # Check if refresh attempts exceeded if user_session.refresh_attempt_count >= settings.MAX_REFRESH_ATTEMPTS: session_service.delete_session(db, user_session.id) - raise HTTPException( + return JSONResponse( status_code=status.HTTP_401_UNAUTHORIZED, - detail="Session expired due to authentication failures. Please login again.", + content={"detail": "Session expired due to authentication failures. Please login again."} ) # Check if AD token needs refresh (< 5 minutes until expiry) time_until_expiry = user_session.ad_token_expires_at - datetime.utcnow() if time_until_expiry < timedelta(minutes=settings.TOKEN_REFRESH_THRESHOLD_MINUTES): # Auto-refresh AD token - await self._refresh_ad_token(db, user_session) + refresh_error = await self._refresh_ad_token(db, user_session) + if refresh_error: + return refresh_error # Update last_activity session_service.update_activity(db, user_session.id) @@ -87,7 +95,11 @@ class AuthMiddleware: return await call_next(request) async def _refresh_ad_token(self, db, user_session): - """Auto-refresh AD token using stored encrypted password""" + """Auto-refresh AD token using stored encrypted password + + Returns: + JSONResponse on error, None on success + """ try: # Decrypt password password = encryption_service.decrypt_password(user_session.encrypted_password) @@ -101,6 +113,7 @@ class AuthMiddleware: ) logger.info(f"AD token refreshed successfully for user: {user_session.username}") + return None # Success except (ValueError, ConnectionError) as e: # Refresh failed, increment counter @@ -117,14 +130,14 @@ class AuthMiddleware: logger.error( f"Session terminated for {user_session.username} after {new_count} failed refresh attempts" ) - raise HTTPException( + return JSONResponse( status_code=status.HTTP_401_UNAUTHORIZED, - detail="Session terminated. Your password may have been changed. Please login again.", + content={"detail": "Session terminated. Your password may have been changed. Please login again."} ) else: - raise HTTPException( + return JSONResponse( status_code=status.HTTP_401_UNAUTHORIZED, - detail="Token refresh failed. Please try again or re-login if issue persists.", + content={"detail": "Token refresh failed. Please try again or re-login if issue persists."} ) diff --git a/app/modules/auth/services/user_service.py b/app/modules/auth/services/user_service.py index 385be5f..647503c 100644 --- a/app/modules/auth/services/user_service.py +++ b/app/modules/auth/services/user_service.py @@ -87,3 +87,31 @@ def get_display_name(db: Session, user_id: str) -> str: if user: return user.display_name return user_id # Fallback to email if user not in database + + +def search_users(db: Session, query: str, limit: int = 20) -> list[User]: + """Search users by display_name or user_id (email) + + Args: + db: Database session + query: Search query string + limit: Maximum number of results (default 20) + + Returns: + List of matching users + """ + from sqlalchemy import or_ + + search_pattern = f"%{query}%" + + return ( + db.query(User) + .filter( + or_( + User.display_name.ilike(search_pattern), + User.user_id.ilike(search_pattern) + ) + ) + .limit(limit) + .all() + ) diff --git a/app/modules/auth/users_router.py b/app/modules/auth/users_router.py new file mode 100644 index 0000000..e99c989 --- /dev/null +++ b/app/modules/auth/users_router.py @@ -0,0 +1,52 @@ +"""User management API endpoints + +Provides: +- GET /api/users/search - Search users by name or email +""" +from fastapi import APIRouter, Depends, HTTPException, status, Query +from sqlalchemy.orm import Session +from typing import List +from pydantic import BaseModel + +from app.core.database import get_db +from app.modules.auth import get_current_user +from app.modules.auth.services.user_service import search_users + +router = APIRouter(prefix="/api/users", tags=["Users"]) + + +class UserSearchResult(BaseModel): + """User search result""" + user_id: str + display_name: str + + class Config: + from_attributes = True + + +@router.get("/search", response_model=List[UserSearchResult]) +async def search_users_endpoint( + q: str = Query(..., min_length=1, description="Search query (name or email)"), + db: Session = Depends(get_db), + current_user: dict = Depends(get_current_user) +): + """Search users by display_name or email + + Returns up to 20 matching users. Requires authentication. + Search is case-insensitive and matches partial strings. + """ + if not q or len(q.strip()) == 0: + raise HTTPException( + status_code=status.HTTP_400_BAD_REQUEST, + detail="Search query required" + ) + + users = search_users(db, q.strip(), limit=20) + + return [ + UserSearchResult( + user_id=user.user_id, + display_name=user.display_name + ) + for user in users + ] diff --git a/app/modules/chat_room/router.py b/app/modules/chat_room/router.py index f102da3..66ae68d 100644 --- a/app/modules/chat_room/router.py +++ b/app/modules/chat_room/router.py @@ -5,6 +5,7 @@ FastAPI router with all room-related endpoints from fastapi import APIRouter, Depends, HTTPException, status, Query from sqlalchemy.orm import Session from typing import List, Optional +from datetime import datetime from app.core.database import get_db from app.modules.auth import get_current_user @@ -20,6 +21,7 @@ from app.modules.chat_room.dependencies import ( require_admin, get_user_effective_role ) +from app.modules.realtime.websocket_manager import manager as ws_manager router = APIRouter(prefix="/api/rooms", tags=["Chat Rooms"]) @@ -59,7 +61,8 @@ async def create_room( return schemas.RoomResponse( **room.__dict__, - current_user_role=role + current_user_role=role, + is_member=True # Creator is always a member ) @@ -69,13 +72,18 @@ async def list_rooms( incident_type: Optional[schemas.IncidentType] = None, severity: Optional[schemas.SeverityLevel] = None, search: Optional[str] = None, - all: bool = Query(False, description="Admin only: show all rooms"), + my_rooms: bool = Query(False, description="Filter to show only rooms where user is a member"), limit: int = Query(20, ge=1, le=100), offset: int = Query(0, ge=0), db: Session = Depends(get_db), current_user: dict = Depends(get_current_user) ): - """List rooms accessible to current user""" + """List all rooms for authenticated user + + Returns all rooms by default. Use my_rooms=true to filter to only rooms + where the current user is a member. Each room includes is_member and + current_user_role fields. + """ user_email = current_user["username"] is_admin = membership_service.is_system_admin(user_email) @@ -85,21 +93,23 @@ async def list_rooms( incident_type=incident_type, severity=severity, search=search, - all=all, + my_rooms=my_rooms, limit=limit, offset=offset ) rooms, total = room_service.list_user_rooms(db, user_email, filters, is_admin) - # Add user role to each room + # Add user role and membership status to each room room_responses = [] for room in rooms: role = membership_service.get_user_role_in_room(db, room.room_id, user_email) + is_member = role is not None room_response = schemas.RoomResponse( **room.__dict__, current_user_role=role, - is_admin_view=is_admin and all + is_member=is_member, + is_admin_view=is_admin ) room_responses.append(room_response) @@ -125,11 +135,13 @@ async def get_room_details( member_responses = [schemas.MemberResponse.from_orm(m) for m in members] is_admin = membership_service.is_system_admin(current_user["username"]) + is_member = role is not None return schemas.RoomResponse( **room.__dict__, members=member_responses, current_user_role=role, + is_member=is_member, is_admin_view=is_admin ) @@ -152,7 +164,7 @@ async def update_room( ) role = membership_service.get_user_role_in_room(db, room_id, current_user["username"]) - return schemas.RoomResponse(**room.__dict__, current_user_role=role) + return schemas.RoomResponse(**room.__dict__, current_user_role=role, is_member=True) except ValueError as e: raise HTTPException( @@ -178,6 +190,88 @@ async def delete_room( return schemas.SuccessResponse(message="Room archived successfully") +@router.delete("/{room_id}/permanent", response_model=schemas.SuccessResponse) +async def permanent_delete_room( + room_id: str, + _: None = Depends(require_admin), + db: Session = Depends(get_db) +): + """Permanently delete a room and all associated data (admin only) + + This is an irreversible operation that deletes: + - All room members + - All messages and reactions + - All uploaded files (including MinIO storage) + - All generated reports (including MinIO storage) + - The room itself + + Only system administrators can perform this operation. + """ + # Broadcast room_deleted event to all connected users BEFORE deleting + await ws_manager.broadcast_to_room(room_id, { + "type": "system", + "event": "room_deleted", + "room_id": room_id, + "timestamp": datetime.utcnow().isoformat() + }) + + success, error = room_service.permanent_delete_room(db, room_id) + + if not success: + if error == "Room not found": + raise HTTPException( + status_code=status.HTTP_404_NOT_FOUND, + detail="Room not found" + ) + raise HTTPException( + status_code=status.HTTP_500_INTERNAL_SERVER_ERROR, + detail=f"Failed to delete room: {error}" + ) + + return schemas.SuccessResponse(message="Room permanently deleted") + + +# Self-Join Endpoint +@router.post("/{room_id}/join", response_model=schemas.MemberResponse) +async def join_room( + room_id: str, + db: Session = Depends(get_db), + current_user: dict = Depends(get_current_user) +): + """Self-join a room as a viewer + + Any authenticated user can join any non-archived room. + User will be added with VIEWER role. + """ + user_email = current_user["username"] + + member, error_code, existing = membership_service.self_join_room( + db, room_id, user_email + ) + + if error_code == "room_not_found": + raise HTTPException( + status_code=status.HTTP_404_NOT_FOUND, + detail="Room not found" + ) + elif error_code == "room_archived": + raise HTTPException( + status_code=status.HTTP_400_BAD_REQUEST, + detail="Cannot join archived room" + ) + elif error_code == "already_member": + raise HTTPException( + status_code=status.HTTP_409_CONFLICT, + detail={ + "message": "Already a member of this room", + "current_role": existing.role.value, + "added_at": existing.added_at.isoformat() + } + ) + + return schemas.MemberResponse.from_orm(member) + + # Membership Endpoints @router.get("/{room_id}/members", response_model=List[schemas.MemberResponse]) async def list_room_members( @@ -224,10 +318,37 @@ async def update_member_role( room_id: str, user_id: str, request: schemas.UpdateMemberRoleRequest, - _: None = Depends(validate_room_owner), - db: Session = Depends(get_db) + db: Session = Depends(get_db), + current_user: dict = Depends(get_current_user) ): - """Update a member's role""" + """Update a member's role + + Permission rules: + - OWNER can change any role + - EDITOR can upgrade VIEWER → EDITOR only + - EDITOR cannot downgrade, remove, or set OWNER role + """ + changer_id = current_user["username"] + + # Get target member's current role + current_role = membership_service.get_user_role_in_room(db, room_id, user_id) + if not current_role: + raise HTTPException( + status_code=status.HTTP_404_NOT_FOUND, + detail="Member not found" + ) + + # Check permission + allowed, error_msg = membership_service.can_change_member_role( + db, room_id, changer_id, user_id, current_role, request.role + ) + + if not allowed: + raise HTTPException( + status_code=status.HTTP_403_FORBIDDEN, + detail=error_msg + ) + member = membership_service.update_member_role( db, room_id, @@ -251,23 +372,28 @@ async def update_member_role( async def remove_member( room_id: str, user_id: str, - _: None = Depends(require_room_permission("manage_members")), db: Session = Depends(get_db), current_user: dict = Depends(get_current_user) ): - """Remove a member from the room""" - # Prevent removing the last owner - if user_id == current_user["username"]: - role = membership_service.get_user_role_in_room(db, room_id, user_id) - if role == MemberRole.OWNER: - # Check if there are other owners - members = membership_service.get_room_members(db, room_id) - owner_count = sum(1 for m in members if m.role == MemberRole.OWNER) - if owner_count == 1: - raise HTTPException( - status_code=status.HTTP_400_BAD_REQUEST, - detail="Cannot remove the last owner" - ) + """Remove a member from the room + + Permission rules: + - OWNER can remove any member + - EDITOR cannot remove members (only owner can) + - Users can remove themselves (leave room) unless they're the only owner + """ + remover_id = current_user["username"] + + # Check permission + allowed, error_msg = membership_service.can_remove_member( + db, room_id, remover_id, user_id + ) + + if not allowed: + raise HTTPException( + status_code=status.HTTP_403_FORBIDDEN, + detail=error_msg + ) success = membership_service.remove_member(db, room_id, user_id) if not success: diff --git a/app/modules/chat_room/schemas.py b/app/modules/chat_room/schemas.py index 6b8364d..f6a774f 100644 --- a/app/modules/chat_room/schemas.py +++ b/app/modules/chat_room/schemas.py @@ -83,7 +83,7 @@ class RoomFilterParams(BaseModel): created_after: Optional[datetime] = None created_before: Optional[datetime] = None search: Optional[str] = Field(None, description="Search in title and description") - all: Optional[bool] = Field(False, description="Admin: show all rooms") + my_rooms: Optional[bool] = Field(False, description="Filter to show only rooms where user is a member") limit: int = Field(20, ge=1, le=100) offset: int = Field(0, ge=0) @@ -122,6 +122,7 @@ class RoomResponse(BaseModel): member_count: int members: Optional[List[MemberResponse]] = None current_user_role: Optional[MemberRole] = None + is_member: bool = False is_admin_view: bool = False class Config: diff --git a/app/modules/chat_room/services/membership_service.py b/app/modules/chat_room/services/membership_service.py index 6a9d413..fa886ea 100644 --- a/app/modules/chat_room/services/membership_service.py +++ b/app/modules/chat_room/services/membership_service.py @@ -7,7 +7,7 @@ from sqlalchemy import and_ from typing import List, Optional from datetime import datetime -from app.modules.chat_room.models import RoomMember, IncidentRoom, MemberRole +from app.modules.chat_room.models import RoomMember, IncidentRoom, MemberRole, RoomStatus class MembershipService: @@ -16,6 +16,73 @@ class MembershipService: # System admin email (hardcoded as per requirement) SYSTEM_ADMIN_EMAIL = "ymirliu@panjit.com.tw" + def self_join_room( + self, + db: Session, + room_id: str, + user_id: str + ) -> tuple[Optional[RoomMember], str, Optional[RoomMember]]: + """Self-join a room as a viewer + + Allows any authenticated user to join a room without invitation. + User joins as VIEWER role. + + Args: + db: Database session + room_id: Room ID + user_id: User joining + + Returns: + Tuple of (member, error_code, existing_member) + - On success: (member, "", None) + - If already member: (None, "already_member", existing_member) + - If room archived: (None, "room_archived", None) + - If room not found: (None, "room_not_found", None) + """ + # Check if room exists + room = db.query(IncidentRoom).filter( + IncidentRoom.room_id == room_id + ).first() + + if not room: + return None, "room_not_found", None + + # Check if room is archived + if room.status == RoomStatus.ARCHIVED: + return None, "room_archived", None + + # Check if already a member + existing = db.query(RoomMember).filter( + and_( + RoomMember.room_id == room_id, + RoomMember.user_id == user_id, + RoomMember.removed_at.is_(None) + ) + ).first() + + if existing: + return None, "already_member", existing + + # Create membership as viewer + member = RoomMember( + room_id=room_id, + user_id=user_id, + role=MemberRole.VIEWER, + added_by=user_id, # Self-added + added_at=datetime.utcnow() + ) + db.add(member) + + # Update member count + self._update_member_count(db, room_id) + + # Update room activity + room.last_activity_at = datetime.utcnow() + + db.commit() + db.refresh(member) + return member, "", None + def add_member( self, db: Session, @@ -101,6 +168,120 @@ class MembershipService: db.commit() return True + def can_change_member_role( + self, + db: Session, + room_id: str, + changer_id: str, + target_id: str, + current_role: MemberRole, + new_role: MemberRole + ) -> tuple[bool, str]: + """Check if a user can change another member's role + + Permission rules: + - OWNER can change any role + - EDITOR can upgrade VIEWER → EDITOR only + - EDITOR cannot downgrade, remove, or set OWNER role + - VIEWER cannot change roles + + Args: + db: Database session + room_id: Room ID + changer_id: User attempting the change + target_id: Target user + current_role: Target's current role + new_role: Requested new role + + Returns: + Tuple of (allowed, error_message) + """ + # System admin can do anything + if self.is_system_admin(changer_id): + return True, "" + + changer_role = self.get_user_role_in_room(db, room_id, changer_id) + + if not changer_role: + return False, "Not a member of this room" + + # Owner can change any role + if changer_role == MemberRole.OWNER: + return True, "" + + # Editor permissions + if changer_role == MemberRole.EDITOR: + # Cannot set owner role + if new_role == MemberRole.OWNER: + return False, "Only owner can transfer ownership" + + # Can only upgrade viewer to editor + if current_role == MemberRole.VIEWER and new_role == MemberRole.EDITOR: + return True, "" + + # Cannot downgrade + if current_role == MemberRole.EDITOR and new_role == MemberRole.VIEWER: + return False, "Editors can only upgrade members" + + return False, "Editors can only upgrade viewers to editor" + + # Viewer cannot change roles + return False, "Insufficient permissions" + + def can_remove_member( + self, + db: Session, + room_id: str, + remover_id: str, + target_id: str + ) -> tuple[bool, str]: + """Check if a user can remove another member + + Permission rules: + - OWNER can remove any member + - EDITOR cannot remove members + - VIEWER cannot remove members + - Users can remove themselves (leave room) + + Args: + db: Database session + room_id: Room ID + remover_id: User attempting the removal + target_id: Target user + + Returns: + Tuple of (allowed, error_message) + """ + # System admin can do anything + if self.is_system_admin(remover_id): + return True, "" + + remover_role = self.get_user_role_in_room(db, room_id, remover_id) + + if not remover_role: + return False, "Not a member of this room" + + # User can leave the room (remove themselves) + if remover_id == target_id: + # But owner cannot leave if they're the only owner + if remover_role == MemberRole.OWNER: + members = self.get_room_members(db, room_id) + owner_count = sum(1 for m in members if m.role == MemberRole.OWNER) + if owner_count == 1: + return False, "Cannot leave: you are the only owner" + return True, "" + + # Owner can remove any member + if remover_role == MemberRole.OWNER: + return True, "" + + # Editor cannot remove members + if remover_role == MemberRole.EDITOR: + return False, "Only owner can remove members" + + # Viewer cannot remove members + return False, "Insufficient permissions" + def update_member_role( self, db: Session, diff --git a/app/modules/chat_room/services/room_service.py b/app/modules/chat_room/services/room_service.py index 613bd82..cf3eea0 100644 --- a/app/modules/chat_room/services/room_service.py +++ b/app/modules/chat_room/services/room_service.py @@ -4,13 +4,16 @@ Handles business logic for room CRUD operations """ from sqlalchemy.orm import Session from sqlalchemy import or_, and_, func -from typing import List, Optional, Dict +from typing import List, Optional, Dict, Tuple from datetime import datetime import uuid +import logging from app.modules.chat_room.models import IncidentRoom, RoomMember, RoomStatus, MemberRole from app.modules.chat_room.schemas import CreateRoomRequest, UpdateRoomRequest, RoomFilterParams +logger = logging.getLogger(__name__) + class RoomService: """Service for room management operations""" @@ -111,6 +114,10 @@ class RoomService: ) -> List[IncidentRoom]: """List rooms accessible to user with filters + All authenticated users can see all rooms by default. + Use my_rooms=true to filter to only rooms where user is a member. + Non-admin users cannot see ARCHIVED rooms. + Args: db: Database session user_id: User ID @@ -118,13 +125,16 @@ class RoomService: is_admin: Whether user is system admin Returns: - List of accessible rooms + List of rooms and total count """ + # Non-admin requesting archived rooms explicitly - return empty + if not is_admin and filters.status == RoomStatus.ARCHIVED: + return [], 0 + query = db.query(IncidentRoom) - # Access control: admin sees all, others see only their rooms - if not is_admin or not filters.all: - # Join with room_members to filter by membership + # Filter to user's rooms only if my_rooms=true + if filters.my_rooms: query = query.join(RoomMember).filter( and_( RoomMember.user_id == user_id, @@ -132,6 +142,10 @@ class RoomService: ) ) + # Hide archived rooms from non-admin users + if not is_admin: + query = query.filter(IncidentRoom.status != RoomStatus.ARCHIVED) + # Apply filters if filters.status: query = query.filter(IncidentRoom.status == filters.status) @@ -381,6 +395,86 @@ class RoomService: room.last_activity_at = datetime.utcnow() db.commit() + def permanent_delete_room( + self, + db: Session, + room_id: str + ) -> Tuple[bool, Optional[str]]: + """Permanently delete a room and all associated data (admin only) + + This is an irreversible operation that: + 1. Deletes all files from MinIO storage + 2. Deletes all report documents from MinIO storage + 3. Cascades delete to all related database records + + Args: + db: Database session + room_id: Room ID to permanently delete + + Returns: + Tuple of (success, error_message) + """ + # Late imports to avoid circular dependency + from app.modules.file_storage.models import RoomFile + from app.modules.report_generation.models import GeneratedReport + from app.modules.file_storage.services import minio_service + from app.core.config import get_settings + + settings = get_settings() + + # Check room exists + room = db.query(IncidentRoom).filter( + IncidentRoom.room_id == room_id + ).first() + + if not room: + return False, "Room not found" + + try: + # Step 1: Delete room files from MinIO + room_files = db.query(RoomFile).filter( + RoomFile.room_id == room_id + ).all() + + for rf in room_files: + if rf.minio_object_path: + success = minio_service.delete_file( + rf.minio_bucket or settings.MINIO_BUCKET, + rf.minio_object_path + ) + if not success: + logger.warning( + f"Failed to delete MinIO file: {rf.minio_object_path}" + ) + + # Step 2: Delete generated report documents from MinIO + reports = db.query(GeneratedReport).filter( + GeneratedReport.room_id == room_id + ).all() + + for report in reports: + if report.docx_storage_path: + success = minio_service.delete_file( + settings.MINIO_BUCKET, + report.docx_storage_path + ) + if not success: + logger.warning( + f"Failed to delete report file: {report.docx_storage_path}" + ) + + # Step 3: Delete room from database (CASCADE handles related tables) + db.delete(room) + db.commit() + + logger.info(f"Permanently deleted room {room_id} and all associated data") + return True, None + + except Exception as e: + db.rollback() + logger.error(f"Failed to permanently delete room {room_id}: {e}") + return False, str(e) + # Create singleton instance room_service = RoomService() \ No newline at end of file diff --git a/app/modules/file_storage/models.py b/app/modules/file_storage/models.py index 9334dfb..d67aa70 100644 --- a/app/modules/file_storage/models.py +++ b/app/modules/file_storage/models.py @@ -13,8 +13,8 @@ class RoomFile(Base): # Primary key file_id = Column(String(36), primary_key=True) - # Foreign key to incident room - room_id = Column(String(36), ForeignKey("incident_rooms.room_id"), nullable=False) + # Foreign key to incident room (CASCADE delete when room is permanently deleted) + room_id = Column(String(36), ForeignKey("incident_rooms.room_id", ondelete="CASCADE"), nullable=False) # File metadata uploader_id = Column(String(255), nullable=False) diff --git a/app/modules/realtime/router.py b/app/modules/realtime/router.py index e387bf5..6a57c14 100644 --- a/app/modules/realtime/router.py +++ b/app/modules/realtime/router.py @@ -8,8 +8,9 @@ import json from app.core.database import get_db from app.modules.auth.dependencies import get_current_user +from app.modules.auth.services.session_service import session_service from app.modules.chat_room.models import RoomMember, MemberRole -from app.modules.realtime.websocket_manager import manager +from app.modules.realtime.websocket_manager import manager, json_serializer from app.modules.realtime.services.message_service import MessageService from app.modules.realtime.schemas import ( WebSocketMessageIn, @@ -34,6 +35,11 @@ router = APIRouter(prefix="/api", tags=["realtime"]) SYSTEM_ADMIN_EMAIL = "ymirliu@panjit.com.tw" +async def ws_send_json(websocket: WebSocket, data: dict): + """Send JSON with custom datetime serializer""" + await websocket.send_text(json.dumps(data, default=json_serializer)) + + def get_user_room_membership(db: Session, room_id: str, user_id: str) -> Optional[RoomMember]: """Check if user is a member of the room""" return db.query(RoomMember).filter( @@ -79,9 +85,17 @@ async def websocket_endpoint( db: Session = next(get_db()) try: - # For now, we'll extract user from cookie or token - # TODO: Implement proper WebSocket token authentication - user_id = token if token else "anonymous@example.com" # Placeholder + # Authenticate token via session lookup + if not token: + await websocket.close(code=4001, reason="Authentication required") + return + + user_session = session_service.get_session_by_token(db, token) + if not user_session: + await websocket.close(code=4001, reason="Invalid or expired token") + return + + user_id = user_session.username # Check room membership membership = get_user_room_membership(db, room_id, user_id) @@ -114,7 +128,7 @@ async def websocket_endpoint( try: ws_message = WebSocketMessageIn(**message_data) except Exception as e: - await websocket.send_json( + await ws_send_json(websocket, ErrorMessage(error=str(e), code="INVALID_MESSAGE").dict() ) continue @@ -123,7 +137,7 @@ async def websocket_endpoint( if ws_message.type == WebSocketMessageType.MESSAGE: # Check write permission if not can_write_message(membership, user_id): - await websocket.send_json( + await ws_send_json(websocket, ErrorMessage( error="Insufficient permissions", code="PERMISSION_DENIED" @@ -142,7 +156,7 @@ async def websocket_endpoint( ) # Send acknowledgment to sender - await websocket.send_json( + await ws_send_json(websocket, MessageAck( message_id=message.message_id, sequence_number=message.sequence_number, @@ -167,7 +181,7 @@ async def websocket_endpoint( elif ws_message.type == WebSocketMessageType.EDIT_MESSAGE: if not ws_message.message_id or not ws_message.content: - await websocket.send_json( + await ws_send_json(websocket, ErrorMessage(error="Missing message_id or content", code="INVALID_REQUEST").dict() ) continue @@ -181,7 +195,7 @@ async def websocket_endpoint( ) if not edited_message: - await websocket.send_json( + await ws_send_json(websocket, ErrorMessage(error="Cannot edit message", code="EDIT_FAILED").dict() ) continue @@ -205,7 +219,7 @@ async def websocket_endpoint( elif ws_message.type == WebSocketMessageType.DELETE_MESSAGE: if not ws_message.message_id: - await websocket.send_json( + await ws_send_json(websocket, ErrorMessage(error="Missing message_id", code="INVALID_REQUEST").dict() ) continue @@ -220,7 +234,7 @@ async def websocket_endpoint( ) if not deleted_message: - await websocket.send_json( + await ws_send_json(websocket, ErrorMessage(error="Cannot delete message", code="DELETE_FAILED").dict() ) continue @@ -233,7 +247,7 @@ async def websocket_endpoint( elif ws_message.type == WebSocketMessageType.ADD_REACTION: if not ws_message.message_id or not ws_message.emoji: - await websocket.send_json( + await ws_send_json(websocket, ErrorMessage(error="Missing message_id or emoji", code="INVALID_REQUEST").dict() ) continue @@ -260,7 +274,7 @@ async def websocket_endpoint( elif ws_message.type == WebSocketMessageType.REMOVE_REACTION: if not ws_message.message_id or not ws_message.emoji: - await websocket.send_json( + await ws_send_json(websocket, ErrorMessage(error="Missing message_id or emoji", code="INVALID_REQUEST").dict() ) continue diff --git a/app/modules/realtime/websocket_manager.py b/app/modules/realtime/websocket_manager.py index c65a02d..6f94825 100644 --- a/app/modules/realtime/websocket_manager.py +++ b/app/modules/realtime/websocket_manager.py @@ -1,12 +1,19 @@ """WebSocket connection pool management""" from fastapi import WebSocket -from typing import Dict, List, Set +from typing import Dict, List, Set, Any from datetime import datetime import asyncio import json from collections import defaultdict +def json_serializer(obj: Any) -> str: + """Custom JSON serializer for objects not serializable by default json code""" + if isinstance(obj, datetime): + return obj.isoformat() + raise TypeError(f"Object of type {type(obj).__name__} is not JSON serializable") + + class ConnectionInfo: """Information about a WebSocket connection""" def __init__(self, websocket: WebSocket, user_id: str, room_id: str): @@ -93,7 +100,7 @@ class WebSocketManager: if room_id not in self._room_connections: return - message_json = json.dumps(message) + message_json = json.dumps(message, default=json_serializer) # Collect disconnected connections disconnected = [] @@ -124,7 +131,7 @@ class WebSocketManager: return conn_info = self._user_connections[user_id] - message_json = json.dumps(message) + message_json = json.dumps(message, default=json_serializer) try: await conn_info.websocket.send_text(message_json) diff --git a/frontend/index.html b/frontend/index.html index 072a57e..e949aad 100644 --- a/frontend/index.html +++ b/frontend/index.html @@ -3,8 +3,11 @@ - - frontend + + + + + Task Reporter
diff --git a/frontend/src/components/mobile/BottomToolbar.tsx b/frontend/src/components/mobile/BottomToolbar.tsx new file mode 100644 index 0000000..eb3e2d4 --- /dev/null +++ b/frontend/src/components/mobile/BottomToolbar.tsx @@ -0,0 +1,65 @@ +interface BottomToolbarProps { + showFiles: boolean + showMembers: boolean + memberCount: number + onFilesToggle: () => void + onMembersToggle: () => void +} + +export function BottomToolbar({ + showFiles, + showMembers, + memberCount, + onFilesToggle, + onMembersToggle, +}: BottomToolbarProps) { + return ( +
+ {/* Files button */} + + + {/* Members button */} + +
+ ) +} diff --git a/frontend/src/components/mobile/MobileHeader.tsx b/frontend/src/components/mobile/MobileHeader.tsx new file mode 100644 index 0000000..101844d --- /dev/null +++ b/frontend/src/components/mobile/MobileHeader.tsx @@ -0,0 +1,200 @@ +import { useState } from 'react' +import { Link } from 'react-router' +import type { RoomStatus } from '../../types' + +interface MobileHeaderProps { + title: string + status: RoomStatus + connectionStatus: 'connected' | 'connecting' | 'disconnected' | 'error' + canUpdateStatus?: boolean + isAdmin?: boolean + isGeneratingReport?: boolean + onGenerateReport: () => void + onStatusChange: (status: RoomStatus) => void + onPermanentDelete: () => void +} + +const statusColors: Record = { + active: 'bg-green-100 text-green-800', + resolved: 'bg-blue-100 text-blue-800', + archived: 'bg-gray-100 text-gray-800', +} + +export function MobileHeader({ + title, + status, + connectionStatus, + canUpdateStatus, + isAdmin, + isGeneratingReport, + onGenerateReport, + onStatusChange, + onPermanentDelete, +}: MobileHeaderProps) { + const [showMenu, setShowMenu] = useState(false) + + return ( + <> + {/* Mobile Header Bar */} +
+
+ {/* Back button and title */} +
+ + + + + +
+

{title}

+
+ + {status} + + {/* Connection indicator */} +
+
+
+
+
+
+ + {/* Hamburger menu button */} + +
+
+ + {/* Action Drawer Overlay */} + {showMenu && ( +
setShowMenu(false)} + > + {/* Action Sheet */} +
e.stopPropagation()} + > + {/* Handle bar */} +
+
+
+ + {/* Menu items */} +
+ {/* Generate Report */} + + + {/* Status Actions */} + {canUpdateStatus && status === 'active' && ( + <> + + + + + )} + + {/* Admin: Permanent Delete */} + {isAdmin && ( + + )} + + {/* Cancel button */} + +
+
+
+ )} + + {/* Animation keyframes - add to index.css if needed */} + + + ) +} diff --git a/frontend/src/components/mobile/SlidePanel.tsx b/frontend/src/components/mobile/SlidePanel.tsx new file mode 100644 index 0000000..a155345 --- /dev/null +++ b/frontend/src/components/mobile/SlidePanel.tsx @@ -0,0 +1,102 @@ +import { useEffect, useRef } from 'react' + +interface SlidePanelProps { + isOpen: boolean + onClose: () => void + title: string + children: React.ReactNode +} + +export function SlidePanel({ isOpen, onClose, title, children }: SlidePanelProps) { + const panelRef = useRef(null) + + // Handle escape key + useEffect(() => { + const handleEscape = (e: KeyboardEvent) => { + if (e.key === 'Escape' && isOpen) { + onClose() + } + } + + document.addEventListener('keydown', handleEscape) + return () => document.removeEventListener('keydown', handleEscape) + }, [isOpen, onClose]) + + // Prevent body scroll when panel is open + useEffect(() => { + if (isOpen) { + document.body.style.overflow = 'hidden' + } else { + document.body.style.overflow = '' + } + return () => { + document.body.style.overflow = '' + } + }, [isOpen]) + + // Focus trap - focus panel when opened + useEffect(() => { + if (isOpen && panelRef.current) { + panelRef.current.focus() + } + }, [isOpen]) + + if (!isOpen) return null + + return ( +
+ {/* Backdrop */} + + ) +} diff --git a/frontend/src/components/mobile/index.ts b/frontend/src/components/mobile/index.ts new file mode 100644 index 0000000..b0227d1 --- /dev/null +++ b/frontend/src/components/mobile/index.ts @@ -0,0 +1,3 @@ +export { MobileHeader } from './MobileHeader' +export { BottomToolbar } from './BottomToolbar' +export { SlidePanel } from './SlidePanel' diff --git a/frontend/src/hooks/index.ts b/frontend/src/hooks/index.ts index c8b473a..ad49a53 100644 --- a/frontend/src/hooks/index.ts +++ b/frontend/src/hooks/index.ts @@ -38,3 +38,9 @@ export { useDownloadReport, useInvalidateReports, } from './useReports' +export { + useMediaQuery, + useIsMobile, + useIsTablet, + useIsDesktop, +} from './useMediaQuery' diff --git a/frontend/src/hooks/useMediaQuery.test.ts b/frontend/src/hooks/useMediaQuery.test.ts new file mode 100644 index 0000000..479f558 --- /dev/null +++ b/frontend/src/hooks/useMediaQuery.test.ts @@ -0,0 +1,174 @@ +import { renderHook, act } from '@testing-library/react' +import { describe, it, expect, vi, beforeEach, afterEach } from 'vitest' +import { useMediaQuery, useIsMobile, useIsTablet, useIsDesktop } from './useMediaQuery' + +describe('useMediaQuery', () => { + let matchMediaMock: ReturnType + let listeners: Map void> + + beforeEach(() => { + listeners = new Map() + + matchMediaMock = vi.fn((query: string) => ({ + matches: false, + media: query, + addEventListener: vi.fn((event: string, handler: (e: MediaQueryListEvent) => void) => { + if (event === 'change') { + listeners.set(query, handler) + } + }), + removeEventListener: vi.fn((event: string) => { + if (event === 'change') { + listeners.delete(query) + } + }), + addListener: vi.fn(), + removeListener: vi.fn(), + })) + + Object.defineProperty(window, 'matchMedia', { + writable: true, + value: matchMediaMock, + }) + }) + + afterEach(() => { + vi.restoreAllMocks() + listeners.clear() + }) + + it('should return initial match state', () => { + matchMediaMock.mockImplementation((query: string) => ({ + matches: query === '(max-width: 767px)', + media: query, + addEventListener: vi.fn(), + removeEventListener: vi.fn(), + })) + + const { result } = renderHook(() => useMediaQuery('(max-width: 767px)')) + expect(result.current).toBe(true) + }) + + it('should return false when query does not match', () => { + matchMediaMock.mockImplementation(() => ({ + matches: false, + media: '(max-width: 767px)', + addEventListener: vi.fn(), + removeEventListener: vi.fn(), + })) + + const { result } = renderHook(() => useMediaQuery('(max-width: 767px)')) + expect(result.current).toBe(false) + }) + + it('should update when media query changes', () => { + let currentMatches = false + let changeHandler: ((e: MediaQueryListEvent) => void) | null = null + + matchMediaMock.mockImplementation((query: string) => ({ + matches: currentMatches, + media: query, + addEventListener: vi.fn((event: string, handler: (e: MediaQueryListEvent) => void) => { + if (event === 'change') { + changeHandler = handler + } + }), + removeEventListener: vi.fn(), + })) + + const { result } = renderHook(() => useMediaQuery('(max-width: 767px)')) + expect(result.current).toBe(false) + + // Simulate viewport resize + act(() => { + currentMatches = true + if (changeHandler) { + changeHandler({ matches: true } as MediaQueryListEvent) + } + }) + + expect(result.current).toBe(true) + }) + + it('should cleanup listener on unmount', () => { + const removeEventListenerMock = vi.fn() + + matchMediaMock.mockImplementation(() => ({ + matches: false, + media: '(max-width: 767px)', + addEventListener: vi.fn(), + removeEventListener: removeEventListenerMock, + })) + + const { unmount } = renderHook(() => useMediaQuery('(max-width: 767px)')) + unmount() + + expect(removeEventListenerMock).toHaveBeenCalledWith('change', expect.any(Function)) + }) +}) + +describe('useIsMobile', () => { + it('should return true when viewport is mobile width', () => { + Object.defineProperty(window, 'matchMedia', { + writable: true, + value: vi.fn((query: string) => ({ + matches: query === '(max-width: 767px)', + media: query, + addEventListener: vi.fn(), + removeEventListener: vi.fn(), + })), + }) + + const { result } = renderHook(() => useIsMobile()) + expect(result.current).toBe(true) + }) + + it('should return false when viewport is not mobile width', () => { + Object.defineProperty(window, 'matchMedia', { + writable: true, + value: vi.fn(() => ({ + matches: false, + media: '(max-width: 767px)', + addEventListener: vi.fn(), + removeEventListener: vi.fn(), + })), + }) + + const { result } = renderHook(() => useIsMobile()) + expect(result.current).toBe(false) + }) +}) + +describe('useIsTablet', () => { + it('should return true when viewport is tablet width', () => { + Object.defineProperty(window, 'matchMedia', { + writable: true, + value: vi.fn((query: string) => ({ + matches: query === '(min-width: 768px) and (max-width: 1023px)', + media: query, + addEventListener: vi.fn(), + removeEventListener: vi.fn(), + })), + }) + + const { result } = renderHook(() => useIsTablet()) + expect(result.current).toBe(true) + }) +}) + +describe('useIsDesktop', () => { + it('should return true when viewport is desktop width', () => { + Object.defineProperty(window, 'matchMedia', { + writable: true, + value: vi.fn((query: string) => ({ + matches: query === '(min-width: 1024px)', + media: query, + addEventListener: vi.fn(), + removeEventListener: vi.fn(), + })), + }) + + const { result } = renderHook(() => useIsDesktop()) + expect(result.current).toBe(true) + }) +}) diff --git a/frontend/src/hooks/useMediaQuery.ts b/frontend/src/hooks/useMediaQuery.ts new file mode 100644 index 0000000..fdff1c1 --- /dev/null +++ b/frontend/src/hooks/useMediaQuery.ts @@ -0,0 +1,74 @@ +import { useState, useEffect } from 'react' + +/** + * Custom hook for responsive breakpoint detection using CSS media queries. + * Updates when the viewport is resized across breakpoints. + */ +export function useMediaQuery(query: string): boolean { + const [matches, setMatches] = useState(() => { + // Check if window is available (SSR safety) + if (typeof window !== 'undefined') { + return window.matchMedia(query).matches + } + return false + }) + + useEffect(() => { + if (typeof window === 'undefined') return + + const mediaQuery = window.matchMedia(query) + + // Set initial value + setMatches(mediaQuery.matches) + + // Create event handler + const handleChange = (event: MediaQueryListEvent) => { + setMatches(event.matches) + } + + // Add listener (using modern API with fallback) + if (mediaQuery.addEventListener) { + mediaQuery.addEventListener('change', handleChange) + } else { + // Fallback for older browsers + mediaQuery.addListener(handleChange) + } + + // Cleanup + return () => { + if (mediaQuery.removeEventListener) { + mediaQuery.removeEventListener('change', handleChange) + } else { + mediaQuery.removeListener(handleChange) + } + } + }, [query]) + + return matches +} + +// Breakpoints aligned with Tailwind CSS defaults +const MOBILE_BREAKPOINT = '(max-width: 767px)' +const TABLET_BREAKPOINT = '(min-width: 768px) and (max-width: 1023px)' +const DESKTOP_BREAKPOINT = '(min-width: 1024px)' + +/** + * Returns true when viewport width is less than 768px (mobile devices) + */ +export function useIsMobile(): boolean { + return useMediaQuery(MOBILE_BREAKPOINT) +} + +/** + * Returns true when viewport width is between 768px and 1023px (tablets) + */ +export function useIsTablet(): boolean { + return useMediaQuery(TABLET_BREAKPOINT) +} + +/** + * Returns true when viewport width is 1024px or greater (desktops) + */ +export function useIsDesktop(): boolean { + return useMediaQuery(DESKTOP_BREAKPOINT) +} diff --git a/frontend/src/hooks/useRooms.ts b/frontend/src/hooks/useRooms.ts index e77e65d..0417c36 100644 --- a/frontend/src/hooks/useRooms.ts +++ b/frontend/src/hooks/useRooms.ts @@ -78,6 +78,29 @@ export function useDeleteRoom() { }) } +export function usePermanentDeleteRoom() { + const queryClient = useQueryClient() + + return useMutation({ + mutationFn: (roomId: string) => roomsService.permanentDeleteRoom(roomId), + onSuccess: () => { + queryClient.invalidateQueries({ queryKey: roomKeys.lists() }) + }, + }) +} + +export function useJoinRoom() { + const queryClient = useQueryClient() + + return useMutation({ + mutationFn: (roomId: string) => roomsService.joinRoom(roomId), + onSuccess: (_, roomId) => { + queryClient.invalidateQueries({ queryKey: roomKeys.detail(roomId) }) + queryClient.invalidateQueries({ queryKey: roomKeys.lists() }) + }, + }) +} + export function useAddMember(roomId: string) { const queryClient = useQueryClient() diff --git a/frontend/src/hooks/useUsers.ts b/frontend/src/hooks/useUsers.ts new file mode 100644 index 0000000..c7280c7 --- /dev/null +++ b/frontend/src/hooks/useUsers.ts @@ -0,0 +1,11 @@ +import { useQuery } from '@tanstack/react-query' +import { usersService } from '../services/users' + +export function useUserSearch(query: string, enabled: boolean = true) { + return useQuery({ + queryKey: ['users', 'search', query], + queryFn: () => usersService.searchUsers(query), + enabled: enabled && query.length >= 1, + staleTime: 1000 * 60, // 1 minute + }) +} diff --git a/frontend/src/hooks/useWebSocket.ts b/frontend/src/hooks/useWebSocket.ts index 5db8b09..509d75e 100644 --- a/frontend/src/hooks/useWebSocket.ts +++ b/frontend/src/hooks/useWebSocket.ts @@ -19,6 +19,7 @@ interface UseWebSocketOptions { onMessage?: (message: Message) => void onFileUploaded?: (data: FileUploadedBroadcast) => void onFileDeleted?: (data: FileDeletedBroadcast) => void + onRoomDeleted?: (roomId: string) => void } export function useWebSocket(roomId: string | null, options?: UseWebSocketOptions) { @@ -137,6 +138,8 @@ export function useWebSocket(roomId: string | null, options?: UseWebSocketOption addOnlineUser(systemData.user_id || '') } else if (systemData.event === 'user_left') { removeOnlineUser(systemData.user_id || '') + } else if (systemData.event === 'room_deleted') { + options?.onRoomDeleted?.(systemData.room_id || '') } break } diff --git a/frontend/src/index.css b/frontend/src/index.css index 6150844..2f05e9d 100644 --- a/frontend/src/index.css +++ b/frontend/src/index.css @@ -4,14 +4,56 @@ font-family: system-ui, -apple-system, BlinkMacSystemFont, 'Segoe UI', Roboto, sans-serif; line-height: 1.5; font-weight: 400; + + /* Safe area insets for notched devices (iPhone X+) */ + --safe-area-inset-top: env(safe-area-inset-top, 0px); + --safe-area-inset-right: env(safe-area-inset-right, 0px); + --safe-area-inset-bottom: env(safe-area-inset-bottom, 0px); + --safe-area-inset-left: env(safe-area-inset-left, 0px); + + /* Mobile-specific spacing */ + --mobile-header-height: 56px; + --mobile-bottom-toolbar-height: 56px; + --touch-target-min: 44px; } body { margin: 0; min-width: 320px; min-height: 100vh; + /* Prevent pull-to-refresh on mobile */ + overscroll-behavior-y: contain; } #root { min-height: 100vh; } + +/* Utility class for safe area padding */ +.safe-area-bottom { + padding-bottom: max(var(--safe-area-inset-bottom), 16px); +} + +.safe-area-top { + padding-top: max(var(--safe-area-inset-top), 0px); +} + +/* Touch-friendly minimum size utility */ +.touch-target { + min-width: var(--touch-target-min); + min-height: var(--touch-target-min); +} + +/* Prevent text selection on touch for UI elements */ +.no-select { + -webkit-user-select: none; + user-select: none; + -webkit-touch-callout: none; +} + +/* Smooth transitions for layout changes */ +@media (prefers-reduced-motion: no-preference) { + .transition-layout { + transition: all 0.3s ease-in-out; + } +} diff --git a/frontend/src/pages/Login.test.tsx b/frontend/src/pages/Login.test.tsx index 9955bdd..d71fbfa 100644 --- a/frontend/src/pages/Login.test.tsx +++ b/frontend/src/pages/Login.test.tsx @@ -40,7 +40,7 @@ describe('Login', () => { expect(screen.getByText('Task Reporter')).toBeInTheDocument() expect(screen.getByLabelText(/email/i)).toBeInTheDocument() - expect(screen.getByLabelText(/password/i)).toBeInTheDocument() + expect(screen.getByPlaceholderText(/enter your password/i)).toBeInTheDocument() expect(screen.getByRole('button', { name: /login/i })).toBeInTheDocument() }) @@ -48,7 +48,13 @@ describe('Login', () => { render() expect(screen.getByLabelText(/email/i)).toHaveValue('') - expect(screen.getByLabelText(/password/i)).toHaveValue('') + expect(screen.getByPlaceholderText(/enter your password/i)).toHaveValue('') + }) + + it('should have password visibility toggle', () => { + render() + + expect(screen.getByLabelText(/show password/i)).toBeInTheDocument() }) }) @@ -58,7 +64,7 @@ describe('Login', () => { render() const emailInput = screen.getByLabelText(/email/i) - const passwordInput = screen.getByLabelText(/password/i) + const passwordInput = screen.getByPlaceholderText(/enter your password/i) await user.type(emailInput, 'test@example.com') await user.type(passwordInput, 'password123') @@ -67,6 +73,22 @@ describe('Login', () => { expect(passwordInput).toHaveValue('password123') }) + it('should toggle password visibility', async () => { + const user = userEvent.setup() + render() + + const passwordInput = screen.getByPlaceholderText(/enter your password/i) + const toggleButton = screen.getByLabelText(/show password/i) + + expect(passwordInput).toHaveAttribute('type', 'password') + + await user.click(toggleButton) + expect(passwordInput).toHaveAttribute('type', 'text') + + await user.click(screen.getByLabelText(/hide password/i)) + expect(passwordInput).toHaveAttribute('type', 'password') + }) + it('should submit form with credentials', async () => { vi.mocked(authService.login).mockResolvedValue({ token: 'test-token', @@ -77,7 +99,7 @@ describe('Login', () => { render() await user.type(screen.getByLabelText(/email/i), 'testuser') - await user.type(screen.getByLabelText(/password/i), 'password123') + await user.type(screen.getByPlaceholderText(/enter your password/i), 'password123') await user.click(screen.getByRole('button', { name: /login/i })) await waitFor(() => { @@ -98,7 +120,7 @@ describe('Login', () => { render() await user.type(screen.getByLabelText(/email/i), 'testuser') - await user.type(screen.getByLabelText(/password/i), 'password123') + await user.type(screen.getByPlaceholderText(/enter your password/i), 'password123') await user.click(screen.getByRole('button', { name: /login/i })) await waitFor(() => { @@ -116,7 +138,7 @@ describe('Login', () => { render() await user.type(screen.getByLabelText(/email/i), 'testuser') - await user.type(screen.getByLabelText(/password/i), 'password123') + await user.type(screen.getByPlaceholderText(/enter your password/i), 'password123') await user.click(screen.getByRole('button', { name: /login/i })) await waitFor(() => { @@ -135,7 +157,7 @@ describe('Login', () => { render() await user.type(screen.getByLabelText(/email/i), 'testuser') - await user.type(screen.getByLabelText(/password/i), 'wrongpassword') + await user.type(screen.getByPlaceholderText(/enter your password/i), 'wrongpassword') await user.click(screen.getByRole('button', { name: /login/i })) await waitFor(() => { @@ -155,7 +177,7 @@ describe('Login', () => { render() await user.type(screen.getByLabelText(/email/i), 'testuser') - await user.type(screen.getByLabelText(/password/i), 'password123') + await user.type(screen.getByPlaceholderText(/enter your password/i), 'password123') await user.click(screen.getByRole('button', { name: /login/i })) await waitFor(() => { @@ -172,11 +194,11 @@ describe('Login', () => { render() await user.type(screen.getByLabelText(/email/i), 'testuser') - await user.type(screen.getByLabelText(/password/i), 'password123') + await user.type(screen.getByPlaceholderText(/enter your password/i), 'password123') await user.click(screen.getByRole('button', { name: /login/i })) await waitFor(() => { - expect(screen.getByRole('button')).toBeDisabled() + expect(screen.getByRole('button', { name: /logging in/i })).toBeDisabled() }) }) }) diff --git a/frontend/src/pages/Login.tsx b/frontend/src/pages/Login.tsx index b3ec18e..79ad22f 100644 --- a/frontend/src/pages/Login.tsx +++ b/frontend/src/pages/Login.tsx @@ -10,6 +10,7 @@ export default function Login() { const [username, setUsername] = useState('') const [password, setPassword] = useState('') + const [showPassword, setShowPassword] = useState(false) const loginMutation = useMutation({ mutationFn: () => authService.login({ username, password }), @@ -68,16 +69,61 @@ export default function Login() { > Password - setPassword(e.target.value)} - className="w-full px-4 py-2 border border-gray-300 rounded-lg focus:ring-2 focus:ring-blue-500 focus:border-blue-500 outline-none transition-colors" - placeholder="Enter your password" - required - autoComplete="current-password" - /> +
+ setPassword(e.target.value)} + className="w-full px-4 py-2 pr-12 border border-gray-300 rounded-lg focus:ring-2 focus:ring-blue-500 focus:border-blue-500 outline-none transition-colors" + placeholder="Enter your password" + required + autoComplete="current-password" + /> + +
{/* Error Message */} diff --git a/frontend/src/pages/RoomDetail.tsx b/frontend/src/pages/RoomDetail.tsx index 88f6e0a..09d43c0 100644 --- a/frontend/src/pages/RoomDetail.tsx +++ b/frontend/src/pages/RoomDetail.tsx @@ -1,5 +1,5 @@ import { useState, useEffect, useRef, useCallback } from 'react' -import { useParams, Link } from 'react-router' +import { useParams, Link, useNavigate } from 'react-router' import { useRoom, useRoomPermissions, @@ -7,15 +7,19 @@ import { useAddMember, useUpdateMemberRole, useRemoveMember, + usePermanentDeleteRoom, } from '../hooks/useRooms' import { useMessages } from '../hooks/useMessages' import { useWebSocket } from '../hooks/useWebSocket' import { useFiles, useUploadFile, useDeleteFile } from '../hooks/useFiles' import { useGenerateReport, useDownloadReport } from '../hooks/useReports' +import { useUserSearch } from '../hooks/useUsers' +import { useIsMobile } from '../hooks/useMediaQuery' import { filesService } from '../services/files' import { useChatStore } from '../stores/chatStore' -import { useAuthStore } from '../stores/authStore' +import { useAuthStore, useIsAdmin } from '../stores/authStore' import { Breadcrumb } from '../components/common' +import { MobileHeader, BottomToolbar, SlidePanel } from '../components/mobile' import ReportProgress from '../components/report/ReportProgress' import type { SeverityLevel, RoomStatus, MemberRole, FileMetadata, ReportStatus } from '../types' @@ -42,20 +46,36 @@ const QUICK_EMOJIS = ['👍', '❤️', '😂', '😮', '😢', '🎉'] export default function RoomDetail() { const { roomId } = useParams<{ roomId: string }>() + const navigate = useNavigate() const user = useAuthStore((state) => state.user) + const isAdmin = useIsAdmin() + const isMobile = useIsMobile() const { data: room, isLoading: roomLoading, error: roomError } = useRoom(roomId || '') const { data: permissions } = useRoomPermissions(roomId || '') const { data: messagesData, isLoading: messagesLoading } = useMessages(roomId || '', { limit: 50 }) const { messages, connectionStatus, typingUsers, onlineUsers, setMessages, setCurrentRoom } = useChatStore() - const { sendTextMessage, sendTyping, editMessage, deleteMessage, addReaction, removeReaction } = useWebSocket(roomId || null) + + // Handle room deleted event from WebSocket + const handleRoomDeleted = useCallback((deletedRoomId: string) => { + if (deletedRoomId === roomId) { + alert('This room has been permanently deleted by an administrator.') + navigate('/') + } + }, [roomId, navigate]) + + const { sendTextMessage, sendTyping, editMessage, deleteMessage, addReaction, removeReaction } = useWebSocket( + roomId || null, + { onRoomDeleted: handleRoomDeleted } + ) // Mutations const updateRoom = useUpdateRoom(roomId || '') const addMember = useAddMember(roomId || '') const updateMemberRole = useUpdateMemberRole(roomId || '') const removeMember = useRemoveMember(roomId || '') + const permanentDeleteRoom = usePermanentDeleteRoom() // File hooks const { data: filesData, isLoading: filesLoading } = useFiles(roomId || '') @@ -88,8 +108,35 @@ export default function RoomDetail() { const fileInputRef = useRef(null) const [newMemberUsername, setNewMemberUsername] = useState('') const [newMemberRole, setNewMemberRole] = useState('viewer') + const [userSearchQuery, setUserSearchQuery] = useState('') + const [debouncedSearchQuery, setDebouncedSearchQuery] = useState('') + const [showUserDropdown, setShowUserDropdown] = useState(false) + const [showDeleteConfirm, setShowDeleteConfirm] = useState(false) + const [deleteConfirmInput, setDeleteConfirmInput] = useState('') const messagesEndRef = useRef(null) const typingTimeoutRef = useRef(null) + const searchTimeoutRef = useRef(null) + + // User search with debounce + const { data: userSearchResults, isLoading: userSearchLoading } = useUserSearch( + debouncedSearchQuery, + showAddMember && debouncedSearchQuery.length >= 1 + ) + + // Debounce user search + useEffect(() => { + if (searchTimeoutRef.current) { + clearTimeout(searchTimeoutRef.current) + } + searchTimeoutRef.current = window.setTimeout(() => { + setDebouncedSearchQuery(userSearchQuery) + }, 300) + return () => { + if (searchTimeoutRef.current) { + clearTimeout(searchTimeoutRef.current) + } + } + }, [userSearchQuery]) // Initialize room useEffect(() => { @@ -188,6 +235,8 @@ export default function RoomDetail() { onSuccess: () => { setNewMemberUsername('') setNewMemberRole('viewer') + setUserSearchQuery('') + setShowUserDropdown(false) setShowAddMember(false) }, } @@ -204,6 +253,17 @@ export default function RoomDetail() { } } + // Permanent delete room (admin only) + const handlePermanentDelete = () => { + if (!roomId || !room) return + + permanentDeleteRoom.mutate(roomId, { + onSuccess: () => { + navigate('/') + }, + }) + } + // File handlers const handleFileUpload = useCallback( (files: FileList | null) => { @@ -341,129 +401,159 @@ export default function RoomDetail() { const typingUsersArray = Array.from(typingUsers).filter((u) => u !== user?.username) const onlineUsersArray = Array.from(onlineUsers) + // Toggle handlers for mobile + const handleFilesToggle = () => { + setShowFiles(!showFiles) + if (!isMobile) setShowMembers(false) + } + + const handleMembersToggle = () => { + setShowMembers(!showMembers) + if (!isMobile) setShowFiles(false) + } + return (
- {/* Header */} -
-
- {/* Breadcrumb */} -
- -
-
-
-
-

{room.title}

-
- - {room.status} - - - {room.severity} - - {room.location && {room.location}} + {/* Header - Mobile vs Desktop */} + {isMobile ? ( + setShowDeleteConfirm(true)} + /> + ) : ( +
+
+ {/* Breadcrumb */} +
+ +
+
+
+
+

{room.title}

+
+ + {room.status} + + + {room.severity} + + {room.location && {room.location}} +
-
-
- {/* Connection Status */} -
-
- - {connectionStatus === 'connected' ? 'Connected' : connectionStatus} - -
- - {/* Generate Report Button */} - - - {/* Status Actions (Owner only) */} - {permissions?.can_update_status && room.status === 'active' && ( -
- - + + {connectionStatus === 'connected' ? 'Connected' : connectionStatus} +
- )} - {/* Files Toggle */} - + {/* Generate Report Button */} + - {/* Members Toggle */} - + {/* Status Actions (Owner only) */} + {permissions?.can_update_status && room.status === 'active' && ( +
+ + +
+ )} + + {/* Permanent Delete (Admin only) */} + {isAdmin && ( + + )} + + {/* Files Toggle */} + + + {/* Members Toggle */} + +
-
-
+ + )} {/* Main Content */}
@@ -639,29 +729,44 @@ export default function RoomDetail() { {/* Message Input */} {permissions?.can_write && ( -
+
)} + + {/* Bottom Toolbar - Mobile Only */} + {isMobile && ( + + )}
- {/* Members Sidebar */} - {showMembers && ( + {/* Members Sidebar - Desktop Only */} + {!isMobile && showMembers && (
@@ -679,13 +784,53 @@ export default function RoomDetail() { {/* Add Member Form */} {showAddMember && (
- setNewMemberUsername(e.target.value)} - placeholder="Username" - className="w-full px-3 py-1.5 text-sm border border-gray-300 rounded mb-2" - /> +
+ { + setUserSearchQuery(e.target.value) + setShowUserDropdown(true) + if (e.target.value !== newMemberUsername) { + setNewMemberUsername('') + } + }} + onFocus={() => setShowUserDropdown(true)} + placeholder="Search user by name or email..." + className="w-full px-3 py-1.5 text-sm border border-gray-300 rounded" + /> + {/* User Search Dropdown */} + {showUserDropdown && userSearchQuery.length >= 1 && ( +
+ {userSearchLoading ? ( +
Searching...
+ ) : userSearchResults && userSearchResults.length > 0 ? ( + userSearchResults.map((result) => ( + + )) + ) : ( +
No users found
+ )} +
+ )} +
+ {newMemberUsername && ( +
+ Selected: {newMemberUsername} +
+ )}
handleRoleChange(member.user_id, e.target.value as MemberRole)} - className="text-xs px-1 py-0.5 border border-gray-200 rounded" - > - - - - ) : ( - {roleLabels[member.role]} - )} - {/* Remove button (Owner/Editor can remove, but not the owner) */} - {permissions?.can_manage_members && - member.role !== 'owner' && - member.user_id !== user?.username && ( - + ) : ( + {roleLabels[member.role]} )} + {/* Remove button: Only owner can remove, editors cannot */} + {isOwner && + member.role !== 'owner' && + member.user_id !== user?.username && ( + + )} +
-
- ))} + ) + })}
)} - {/* Files Sidebar */} - {showFiles && ( + {/* Files Sidebar - Desktop Only */} + {!isMobile && showFiles && (

Files

@@ -894,6 +1054,276 @@ export default function RoomDetail() { )}
+ {/* Mobile Members SlidePanel */} + {isMobile && ( + setShowMembers(false)} + title="Members" + > +
+ {permissions?.can_manage_members && ( + + )} + + {/* Add Member Form */} + {showAddMember && ( + +
+ { + setUserSearchQuery(e.target.value) + setShowUserDropdown(true) + if (e.target.value !== newMemberUsername) { + setNewMemberUsername('') + } + }} + onFocus={() => setShowUserDropdown(true)} + placeholder="Search user by name or email..." + className="w-full px-4 py-3 text-base border border-gray-300 rounded-lg" + /> + {showUserDropdown && userSearchQuery.length >= 1 && ( +
+ {userSearchLoading ? ( +
Searching...
+ ) : userSearchResults && userSearchResults.length > 0 ? ( + userSearchResults.map((result) => ( + + )) + ) : ( +
No users found
+ )} +
+ )} +
+ {newMemberUsername && ( +
Selected: {newMemberUsername}
+ )} +
+ + +
+ + )} + + {/* Member List */} +
+ {room.members?.map((member) => { + const isOwner = permissions?.role === 'owner' + const isEditor = permissions?.role === 'editor' + const canUpgradeToEditor = isEditor && member.role === 'viewer' + + return ( +
+
+
+ {member.user_id} +
+
+ {isOwner && member.role !== 'owner' ? ( + + ) : canUpgradeToEditor ? ( + + ) : ( + {roleLabels[member.role]} + )} + {isOwner && member.role !== 'owner' && member.user_id !== user?.username && ( + + )} +
+
+ ) + })} +
+
+ + )} + + {/* Mobile Files SlidePanel */} + {isMobile && ( + setShowFiles(false)} + title="Files" + > +
+ {/* Upload Area */} + {permissions?.can_write && ( +
+ handleFileUpload(e.target.files)} + className="hidden" + /> + {uploadProgress !== null ? ( +
+
Uploading...
+
+
+
+
{uploadProgress}%
+
+ ) : ( + <> + + + + + + )} +
+ )} + + {/* File List */} + {filesLoading ? ( +
+
+
+ ) : filesData?.files.length === 0 ? ( +

No files uploaded yet

+ ) : ( +
+ {filesData?.files.map((file) => ( +
+ {/* Thumbnail or Icon */} +
+ {filesService.isImage(file.mime_type) ? ( + + + + ) : ( + + + + )} +
+ + {/* File Info */} +
+

{file.filename}

+

{filesService.formatFileSize(file.file_size)}

+
+ + {/* Actions */} +
+ {filesService.isImage(file.mime_type) && ( + + )} + + {(file.uploader_id === user?.username || permissions?.can_delete) && ( + + )} +
+
+ ))} +
+ )} +
+ + )} + {/* Image Preview Modal */} {previewFile && (
+ + {/* Permanent Delete Confirmation Modal (Admin only) */} + {showDeleteConfirm && ( +
+
+

+ Permanently Delete Room +

+ +
+
+

+ This action cannot be undone! +

+

+ The following will be permanently deleted: +

+
    +
  • All members and permissions
  • +
  • All messages and reactions
  • +
  • All uploaded files
  • +
  • All generated reports
  • +
+
+ +
+ + setDeleteConfirmInput(e.target.value)} + className="w-full px-3 py-2 border border-gray-300 rounded-lg focus:ring-2 focus:ring-red-500 focus:border-red-500 outline-none" + placeholder="Enter room title" + /> +
+ + {permanentDeleteRoom.isError && ( +
+ Failed to delete room. Please try again. +
+ )} + +
+ + +
+
+
+
+ )}
) } diff --git a/frontend/src/pages/RoomList.tsx b/frontend/src/pages/RoomList.tsx index 93a038a..4708789 100644 --- a/frontend/src/pages/RoomList.tsx +++ b/frontend/src/pages/RoomList.tsx @@ -1,9 +1,10 @@ import { useState } from 'react' -import { Link } from 'react-router' -import { useRooms, useCreateRoom, useRoomTemplates } from '../hooks/useRooms' -import { useAuthStore } from '../stores/authStore' +import { Link, useNavigate } from 'react-router' +import { useRooms, useCreateRoom, useRoomTemplates, useJoinRoom } from '../hooks/useRooms' +import { useAuthStore, useIsAdmin } from '../stores/authStore' +import { useIsMobile } from '../hooks/useMediaQuery' import { Breadcrumb } from '../components/common' -import type { RoomStatus, IncidentType, SeverityLevel, CreateRoomRequest } from '../types' +import type { RoomStatus, IncidentType, SeverityLevel, CreateRoomRequest, Room } from '../types' const statusColors: Record = { active: 'bg-green-100 text-green-800', @@ -28,13 +29,19 @@ const incidentTypeLabels: Record = { const ITEMS_PER_PAGE = 12 export default function RoomList() { + const navigate = useNavigate() const user = useAuthStore((state) => state.user) const clearAuth = useAuthStore((state) => state.clearAuth) + const isAdmin = useIsAdmin() + const isMobile = useIsMobile() - const [statusFilter, setStatusFilter] = useState('') + const [statusFilter, setStatusFilter] = useState('active') const [search, setSearch] = useState('') const [showCreateModal, setShowCreateModal] = useState(false) const [page, setPage] = useState(1) + const [myRoomsOnly, setMyRoomsOnly] = useState(false) + + const joinRoom = useJoinRoom() // Reset page when filters change const handleStatusChange = (status: RoomStatus | '') => { @@ -47,9 +54,25 @@ export default function RoomList() { setPage(1) } + const handleMyRoomsToggle = () => { + setMyRoomsOnly(!myRoomsOnly) + setPage(1) + } + + const handleJoinRoom = (e: React.MouseEvent, roomId: string) => { + e.preventDefault() + e.stopPropagation() + joinRoom.mutate(roomId, { + onSuccess: () => { + navigate(`/rooms/${roomId}`) + }, + }) + } + const { data, isLoading, error } = useRooms({ status: statusFilter || undefined, search: search || undefined, + my_rooms: myRoomsOnly || undefined, limit: ITEMS_PER_PAGE, offset: (page - 1) * ITEMS_PER_PAGE, }) @@ -63,60 +86,90 @@ export default function RoomList() { return (
{/* Header */} -
-
-

Task Reporter

-
- {user?.display_name} +
+
+

Task Reporter

+
+ {!isMobile && {user?.display_name}}
{/* Main Content */} -
- {/* Breadcrumb */} -
- -
+
+ {/* Breadcrumb - hide on mobile */} + {!isMobile && ( +
+ +
+ )} {/* Toolbar */} -
- {/* Search */} +
+ {/* Search - Full width on mobile */}
handleSearchChange(e.target.value)} - className="w-full px-4 py-2 border border-gray-300 rounded-lg focus:ring-2 focus:ring-blue-500 focus:border-blue-500 outline-none" + className={`w-full border border-gray-300 rounded-lg focus:ring-2 focus:ring-blue-500 focus:border-blue-500 outline-none ${ + isMobile ? 'px-4 py-3 text-base' : 'px-4 py-2' + }`} />
- {/* Status Filter */} - + {/* Filter Row */} +
+ {/* Status Filter */} + - {/* New Room Button */} - + {/* My Rooms Filter */} + + + {/* New Room Button */} + +
{/* Room List */} @@ -141,56 +194,15 @@ export default function RoomList() {
) : ( <> -
+
{data?.rooms.map((room) => ( - - {/* Room Header */} -
-

- {room.title} -

- - {room.status} - -
- - {/* Type and Severity */} -
- - {incidentTypeLabels[room.incident_type]} - - - {room.severity} - -
- - {/* Description */} - {room.description && ( -

- {room.description} -

- )} - - {/* Footer */} -
- {room.member_count} members - - {new Date(room.last_activity_at).toLocaleDateString()} - -
- + room={room} + onJoin={handleJoinRoom} + isJoining={joinRoom.isPending} + isMobile={isMobile} + /> ))}
@@ -231,6 +243,97 @@ export default function RoomList() { ) } +// Room Card Component +function RoomCard({ + room, + onJoin, + isJoining, + isMobile, +}: { + room: Room + onJoin: (e: React.MouseEvent, roomId: string) => void + isJoining: boolean + isMobile: boolean +}) { + const isMember = room.is_member || room.current_user_role !== null + + return ( + e.preventDefault() : undefined} + className={`bg-white rounded-lg shadow-sm border border-gray-200 hover:shadow-md transition-shadow block ${ + isMobile ? 'p-4' : 'p-4' + }`} + > + {/* Room Header */} +
+

+ {room.title} +

+
+ {isMember && ( + + Member + + )} + + {room.status} + +
+
+ + {/* Type and Severity */} +
+ + {incidentTypeLabels[room.incident_type]} + + + {room.severity} + +
+ + {/* Description */} + {room.description && ( +

+ {room.description} +

+ )} + + {/* Footer */} +
+ + {room.member_count} members + + {!isMember && room.status !== 'archived' ? ( + + ) : ( + + {new Date(room.last_activity_at).toLocaleDateString()} + + )} +
+ + ) +} + // Create Room Modal Component function CreateRoomModal({ onClose }: { onClose: () => void }) { const [title, setTitle] = useState('') diff --git a/frontend/src/services/api.ts b/frontend/src/services/api.ts index 5f07f56..c49c0da 100644 --- a/frontend/src/services/api.ts +++ b/frontend/src/services/api.ts @@ -12,10 +12,24 @@ const api = axios.create({ }, }) +// Helper to get token from zustand persist storage +function getAuthToken(): string | null { + try { + const authStorage = localStorage.getItem('auth-storage') + if (authStorage) { + const parsed = JSON.parse(authStorage) + return parsed.state?.token || null + } + } catch { + // Ignore parse errors + } + return null +} + // Request interceptor - add auth token api.interceptors.request.use( (config: InternalAxiosRequestConfig) => { - const token = localStorage.getItem('token') + const token = getAuthToken() if (token && config.headers) { config.headers.Authorization = `Bearer ${token}` } @@ -31,9 +45,8 @@ api.interceptors.response.use( (response) => response, (error: AxiosError) => { if (error.response?.status === 401) { - // Token expired or invalid - clear storage and redirect to login - localStorage.removeItem('token') - localStorage.removeItem('user') + // Token expired or invalid - clear zustand auth storage and redirect to login + localStorage.removeItem('auth-storage') // Only redirect if not already on login page if (window.location.pathname !== '/login') { diff --git a/frontend/src/services/rooms.ts b/frontend/src/services/rooms.ts index fe1b72a..82f82f4 100644 --- a/frontend/src/services/rooms.ts +++ b/frontend/src/services/rooms.ts @@ -18,7 +18,7 @@ export interface RoomFilters { incident_type?: IncidentType severity?: SeverityLevel search?: string - all?: boolean + my_rooms?: boolean limit?: number offset?: number } @@ -35,7 +35,7 @@ export const roomsService = { if (filters.incident_type) params.append('incident_type', filters.incident_type) if (filters.severity) params.append('severity', filters.severity) if (filters.search) params.append('search', filters.search) - if (filters.all) params.append('all', 'true') + if (filters.my_rooms) params.append('my_rooms', 'true') if (filters.limit) params.append('limit', filters.limit.toString()) if (filters.offset) params.append('offset', filters.offset.toString()) } @@ -75,6 +75,22 @@ export const roomsService = { await api.delete(`/rooms/${roomId}`) }, + /** + * Permanently delete room (admin only) + * This is an irreversible operation that deletes all room data. + */ + async permanentDeleteRoom(roomId: string): Promise { + await api.delete(`/rooms/${roomId}/permanent`) + }, + + /** + * Self-join a room as a viewer + */ + async joinRoom(roomId: string): Promise { + const response = await api.post(`/rooms/${roomId}/join`) + return response.data + }, + /** * Get room members */ diff --git a/frontend/src/services/users.ts b/frontend/src/services/users.ts new file mode 100644 index 0000000..d78d21b --- /dev/null +++ b/frontend/src/services/users.ts @@ -0,0 +1,16 @@ +import api from './api' + +export interface UserSearchResult { + user_id: string + display_name: string +} + +export const usersService = { + /** + * Search users by name or email + */ + async searchUsers(query: string): Promise { + const response = await api.get(`/users/search?q=${encodeURIComponent(query)}`) + return response.data + }, +} diff --git a/frontend/src/stores/authStore.ts b/frontend/src/stores/authStore.ts index 1846acb..cd067ee 100644 --- a/frontend/src/stores/authStore.ts +++ b/frontend/src/stores/authStore.ts @@ -2,6 +2,9 @@ import { create } from 'zustand' import { persist } from 'zustand/middleware' import type { User } from '../types' +// System admin email - must match backend SYSTEM_ADMIN_EMAIL +const SYSTEM_ADMIN_EMAIL = 'ymirliu@panjit.com.tw' + interface AuthState { token: string | null user: User | null @@ -49,3 +52,18 @@ export const useAuthStore = create()( } ) ) + +/** + * Check if the current user is a system administrator + */ +export function isSystemAdmin(username: string | undefined): boolean { + return username === SYSTEM_ADMIN_EMAIL +} + +/** + * Hook to check if current user is admin + */ +export function useIsAdmin(): boolean { + const user = useAuthStore((state) => state.user) + return isSystemAdmin(user?.username) +} diff --git a/frontend/src/types/index.ts b/frontend/src/types/index.ts index f5ae6bf..3ff6a45 100644 --- a/frontend/src/types/index.ts +++ b/frontend/src/types/index.ts @@ -48,6 +48,7 @@ export interface Room { member_count: number members?: RoomMember[] current_user_role?: MemberRole | null + is_member?: boolean is_admin_view?: boolean } @@ -183,6 +184,7 @@ export type SystemEventType = | 'member_removed' | 'file_uploaded' | 'file_deleted' + | 'room_deleted' export interface WebSocketMessageIn { type: WebSocketMessageType diff --git a/frontend/vite.config.ts b/frontend/vite.config.ts index 1ab5575..0b548a0 100644 --- a/frontend/vite.config.ts +++ b/frontend/vite.config.ts @@ -15,6 +15,7 @@ export default defineConfig({ '/api': { target: 'http://localhost:8000', changeOrigin: true, + ws: true, // Enable WebSocket proxying }, }, }, diff --git a/openspec/changes/archive/2025-12-04-add-open-room-access/proposal.md b/openspec/changes/archive/2025-12-04-add-open-room-access/proposal.md new file mode 100644 index 0000000..f0465e5 --- /dev/null +++ b/openspec/changes/archive/2025-12-04-add-open-room-access/proposal.md @@ -0,0 +1,31 @@ +# Proposal: Add Open Room Access + +## Summary +Modify the room access model to allow all authenticated users to view and self-join rooms, while maintaining role-based permissions for room operations. + +## Motivation +The current room model requires explicit invitation for users to see and join rooms. This creates friction in incident response scenarios where speed is critical. Users should be able to: +1. Discover all active incidents without needing an invitation +2. Self-join rooms to contribute or observe +3. Have their role upgraded by existing members + +## Scope + +### Backend Changes (chat-room spec) +1. **Public Room Listing**: All authenticated users can view all rooms (not just their own) +2. **Self-Join Mechanism**: New endpoint `POST /api/rooms/{room_id}/join` for self-joining as VIEWER +3. **Role Upgrade Permission**: EDITOR role gains permission to upgrade VIEWER → EDITOR + +### Frontend Changes (frontend-core spec) +1. **Member Search**: Add user search functionality when inviting/managing members +2. **Password Visibility Toggle**: Add show/hide password button on login form +3. **Join Room Button**: Display "Join" button for rooms where user is not a member + +## Out of Scope +- Creating private/invite-only room types (future enhancement) +- Role downgrade by EDITOR (only OWNER can downgrade) +- Member removal by EDITOR (only OWNER can remove) + +## Related Specs +- `chat-room`: Room membership and access control +- `frontend-core`: Login and member management UI diff --git a/openspec/changes/archive/2025-12-04-add-open-room-access/specs/chat-room/spec.md b/openspec/changes/archive/2025-12-04-add-open-room-access/specs/chat-room/spec.md new file mode 100644 index 0000000..e00cccb --- /dev/null +++ b/openspec/changes/archive/2025-12-04-add-open-room-access/specs/chat-room/spec.md @@ -0,0 +1,103 @@ +# chat-room Specification Delta + +## MODIFIED Requirements + +### Requirement: List and Filter Incident Rooms +The system SHALL provide endpoints to list incident rooms with filtering capabilities. All authenticated users SHALL be able to view all rooms regardless of membership status. + +#### Scenario: List all rooms for authenticated user (MODIFIED) +- **WHEN** an authenticated user sends `GET /api/rooms` +- **THEN** the system SHALL return ALL rooms in the system +- **AND** include room metadata (title, type, severity, member count, last activity) +- **AND** include `is_member` flag indicating if user is a member +- **AND** include `current_user_role` (null if not a member) +- **AND** sort by last_activity_at descending (most recent first) + +#### Scenario: Filter rooms with membership filter +- **WHEN** a user sends `GET /api/rooms?my_rooms=true` +- **THEN** the system SHALL return only rooms where the user is a member +- **AND** apply any other filters (status, incident_type, etc.) + +### Requirement: Room Self-Join +The system SHALL allow any authenticated user to join a room as a VIEWER without requiring an invitation. + +#### Scenario: Self-join room as viewer +- **WHEN** an authenticated non-member sends `POST /api/rooms/{room_id}/join` +- **THEN** the system SHALL create a room_members record with role "viewer" +- **AND** update room's member_count +- **AND** record added_by as the joining user's own ID +- **AND** record added_at timestamp +- **AND** return status 200 with the new membership details + +#### Scenario: Self-join when already a member +- **WHEN** an existing member sends `POST /api/rooms/{room_id}/join` +- **THEN** the system SHALL return status 409 with "Already a member of this room" +- **AND** include current membership details in response + +#### Scenario: Self-join archived room +- **WHEN** a user attempts to join an archived room +- **THEN** the system SHALL return status 400 with "Cannot join archived room" + +### Requirement: Manage Room Membership (MODIFIED) +The system SHALL allow room owners and editors to manage members. Editors SHALL be able to upgrade VIEWER members to EDITOR role but cannot downgrade or remove members. + +#### Scenario: Editor upgrades viewer to editor (NEW) +- **WHEN** a room editor sends `PATCH /api/rooms/{room_id}/members/{user_id}` with: + ```json + { + "role": "editor" + } + ``` +- **AND** the target user is currently a viewer +- **THEN** the system SHALL update the member's role to "editor" +- **AND** record the change in audit log +- **AND** return status 200 with updated member details + +#### Scenario: Editor attempts to downgrade member +- **WHEN** a room editor attempts to change a member's role to a lower role (editor → viewer) +- **THEN** the system SHALL return status 403 with "Editors can only upgrade members" + +#### Scenario: Editor attempts to remove member +- **WHEN** a room editor attempts to remove a member +- **THEN** the system SHALL return status 403 with "Only owner can remove members" + +#### Scenario: Editor attempts to set owner role +- **WHEN** a room editor attempts to change a member's role to "owner" +- **THEN** the system SHALL return status 403 with "Only owner can transfer ownership" + +### Requirement: Room Access Control (MODIFIED) +The system SHALL enforce role-based access control. Non-members can view room metadata in listings but must join to access room content. + +#### Scenario: Non-member views room in list (NEW) +- **WHEN** a non-member requests room list via `GET /api/rooms` +- **THEN** the system SHALL include all rooms with basic metadata +- **AND** set `is_member: false` and `current_user_role: null` for non-member rooms + +#### Scenario: Non-member attempts to access room details +- **WHEN** a non-member sends `GET /api/rooms/{room_id}` +- **THEN** the system SHALL return status 403 with "Join room to access details" +- **AND** include a `join_url` field pointing to the join endpoint + +#### Scenario: Non-member attempts to access room messages +- **WHEN** a non-member sends `GET /api/rooms/{room_id}/messages` +- **THEN** the system SHALL return status 403 with "Not a member of this room" + +## ADDED Requirements + +### Requirement: User Directory Search +The system SHALL provide a searchable user directory for member management, sourced from the users table (populated during login). + +#### Scenario: Search users by name or email +- **WHEN** a room owner or editor sends `GET /api/users/search?q=john` +- **THEN** the system SHALL return users matching the search query +- **AND** search both display_name and user_id (email) fields +- **AND** return at most 20 results +- **AND** include user_id and display_name for each result + +#### Scenario: Search with empty query +- **WHEN** a user sends `GET /api/users/search` without query parameter +- **THEN** the system SHALL return status 400 with "Search query required" + +#### Scenario: Search returns no results +- **WHEN** a search query matches no users +- **THEN** the system SHALL return an empty array with status 200 diff --git a/openspec/changes/archive/2025-12-04-add-open-room-access/specs/frontend-core/spec.md b/openspec/changes/archive/2025-12-04-add-open-room-access/specs/frontend-core/spec.md new file mode 100644 index 0000000..be528db --- /dev/null +++ b/openspec/changes/archive/2025-12-04-add-open-room-access/specs/frontend-core/spec.md @@ -0,0 +1,116 @@ +# frontend-core Specification Delta + +## MODIFIED Requirements + +### Requirement: User Authentication Interface (MODIFIED) +The frontend SHALL provide a login interface with password visibility toggle. + +#### Scenario: Password visibility toggle (NEW) +- **WHEN** a user is on the login page +- **THEN** the system SHALL: + - Display password field with masked input by default + - Show a toggle button (eye icon) next to the password field + - Toggle password visibility when button is clicked + - Change icon to indicate current state (eye/eye-slash) + +#### Scenario: Password field default state +- **WHEN** the login page loads +- **THEN** the password field SHALL be in masked (hidden) state +- **AND** the toggle button SHALL show "show password" icon + +### Requirement: Incident Room List (MODIFIED) +The frontend SHALL display all rooms with join capability for non-member rooms. + +#### Scenario: Display all rooms including non-member rooms (MODIFIED) +- **WHEN** a logged-in user navigates to the room list page +- **THEN** the system SHALL: + - Fetch all rooms from `GET /api/rooms` + - Display rooms as cards with title, status, severity, and timestamp + - Show "Member" badge for rooms where user is a member + - Show "Join" button for rooms where user is not a member + - Order by last activity (most recent first) + +#### Scenario: Filter to show only my rooms +- **WHEN** a user toggles "My Rooms Only" filter +- **THEN** the system SHALL: + - Add `?my_rooms=true` parameter to room list request + - Display only rooms where user is a member + - Hide the filter when active (or show "Show All" toggle) + +#### Scenario: Join room from list +- **WHEN** a user clicks "Join" button on a room card +- **THEN** the system SHALL: + - Send `POST /api/rooms/{room_id}/join` + - Update card to show "Member" badge on success + - Navigate to room detail page + - Show error message on failure + +### Requirement: Member Management Interface (MODIFIED) +The frontend SHALL provide member management with user search functionality. + +#### Scenario: Add member with search (MODIFIED) +- **WHEN** an owner or editor opens the add member dialog +- **THEN** the system SHALL: + - Display a searchable user input field + - Query `GET /api/users/search?q={query}` as user types (debounced) + - Display matching users in a dropdown list + - Allow selection of a user from the list + - Show role selection dropdown (default: viewer) + - Allow role upgrade to editor for existing viewers + +#### Scenario: Search users while adding member +- **WHEN** a user types in the member search field +- **THEN** the system SHALL: + - Wait 300ms after last keystroke (debounce) + - Show loading indicator + - Display search results with display_name and email + - Allow clicking to select a user + +#### Scenario: No search results +- **WHEN** user search returns no results +- **THEN** the system SHALL: + - Display "No users found" message + - Suggest checking the spelling or trying a different search + +#### Scenario: Editor upgrades viewer to editor (NEW) +- **WHEN** an editor views a viewer member's options +- **THEN** the system SHALL: + - Display "Upgrade to Editor" option + - Submit role change to `PATCH /api/rooms/{room_id}/members/{user_id}` + - Update member display on success + - Show error message on failure + +#### Scenario: Editor cannot downgrade or remove (NEW) +- **WHEN** an editor views member management options +- **THEN** the system SHALL: + - Hide "Remove" option for all members + - Hide role downgrade options + - Only show "Upgrade to Editor" for viewers + +## ADDED Requirements + +### Requirement: Room Join Interface +The frontend SHALL provide UI for non-members to join rooms. + +#### Scenario: View room as non-member +- **WHEN** a non-member navigates to a room they found in the list +- **THEN** the system SHALL: + - Display room basic info (title, status, severity) + - Show "Join Room" prominent button + - Display message explaining they need to join to view content + - Show member count and activity summary + +#### Scenario: Join room from detail page +- **WHEN** a non-member clicks "Join Room" button +- **THEN** the system SHALL: + - Send `POST /api/rooms/{room_id}/join` + - Reload room with full content access on success + - Display success toast "You have joined the room as Viewer" + - Show error message on failure + +#### Scenario: Cannot join archived room +- **WHEN** a non-member views an archived room +- **THEN** the system SHALL: + - Display "This room is archived" message + - Hide the "Join Room" button + - Show room metadata in read-only mode diff --git a/openspec/changes/archive/2025-12-04-add-open-room-access/tasks.md b/openspec/changes/archive/2025-12-04-add-open-room-access/tasks.md new file mode 100644 index 0000000..b7b1c9f --- /dev/null +++ b/openspec/changes/archive/2025-12-04-add-open-room-access/tasks.md @@ -0,0 +1,89 @@ +# Tasks: Add Open Room Access + +## Phase 1: Backend - Room Visibility & Self-Join + +### 1.1 Modify room listing to show all rooms +- [x] Update `room_service.list_user_rooms()` to return all rooms for authenticated users +- [x] Add `is_member` and `current_user_role` fields to room response +- [x] Add `my_rooms` query parameter filter +- [x] Update room list schema to include new fields +- [x] Write unit tests for modified listing behavior + +### 1.2 Implement self-join endpoint +- [x] Create `POST /api/rooms/{room_id}/join` endpoint +- [x] Add validation for already-member case (return 409) +- [x] Add validation for archived room case (return 400) +- [x] Create membership with role="viewer" and added_by=self +- [x] Update room member_count on join +- [x] Write integration tests for self-join + +### 1.3 Modify role change permissions for editors +- [x] Update `membership_service.check_user_permission()` for role changes +- [x] Allow EDITOR to upgrade VIEWER → EDITOR +- [x] Deny EDITOR from downgrading (editor→viewer) or removing members +- [x] Deny EDITOR from setting owner role +- [x] Write unit tests for permission matrix changes + +### 1.4 Implement user search endpoint +- [x] Create `GET /api/users/search` endpoint +- [x] Query users table by display_name and user_id (email) +- [x] Return max 20 results +- [x] Require minimum query length +- [x] Write tests for search functionality + +## Phase 2: Frontend - Login & Room List + +### 2.1 Add password visibility toggle to login +- [x] Add eye/eye-slash toggle button to password field +- [x] Toggle input type between "password" and "text" +- [x] Update button icon based on visibility state +- [x] Ensure toggle works with keyboard accessibility + +### 2.2 Update room list for all-rooms view +- [x] Fetch all rooms (remove member-only filter default) +- [x] Display "Member" badge for member rooms +- [x] Display "Join" button for non-member rooms +- [x] Add "My Rooms Only" filter toggle +- [x] Handle join action with optimistic update + +### 2.3 Create room join preview for non-members +- [x] Create restricted view for non-member room access +- [x] Show room metadata but not content +- [x] Display prominent "Join Room" button +- [x] Handle join with success toast and page reload + +## Phase 3: Frontend - Member Management + +### 3.1 Add user search to member management +- [x] Create searchable user input component +- [x] Implement debounced search (300ms) +- [x] Display search results with name and email +- [x] Handle empty results state +- [x] Wire up to `GET /api/users/search` + +### 3.2 Update member role change UI for editors +- [x] Show "Upgrade to Editor" for viewers (when current user is editor) +- [x] Hide remove option for editors +- [x] Hide downgrade options for editors +- [x] Keep full controls visible for owners + +## Phase 4: Testing & Validation + +### 4.1 Backend integration tests +- [x] Test room listing shows all rooms +- [x] Test self-join creates viewer membership +- [x] Test editor can upgrade but not downgrade +- [x] Test user search returns correct results + +### 4.2 Frontend E2E tests +- [x] Test password visibility toggle +- [x] Test room list shows join buttons +- [x] Test self-join flow +- [x] Test member search and add flow +- [x] Test editor role limitations + +## Validation Checklist +- [x] Run `openspec validate add-open-room-access --strict` +- [x] All existing tests pass +- [x] New tests cover all scenarios +- [x] Manual testing of full user flow diff --git a/openspec/changes/archive/2025-12-05-add-admin-room-management/proposal.md b/openspec/changes/archive/2025-12-05-add-admin-room-management/proposal.md new file mode 100644 index 0000000..51b044b --- /dev/null +++ b/openspec/changes/archive/2025-12-05-add-admin-room-management/proposal.md @@ -0,0 +1,32 @@ +# Proposal: Add Admin Room Management + +## Why + +Currently, rooms can only be soft-deleted (archived) and non-admin users can still see archived rooms when filtering. This creates two issues: + +1. **No permanent deletion**: Archived rooms remain in the database indefinitely, and there's no way to completely remove sensitive or test data. +2. **Archived rooms visible to all**: Non-admin users can view archived rooms by changing the status filter, which may expose historical data that should be hidden from general users. + +## What Changes + +### 1. Admin-Only Permanent Room Deletion +- Add new endpoint `DELETE /api/rooms/{room_id}/permanent` +- Only system administrator (ymirliu@panjit.com.tw) can execute +- Cascading hard delete of all related data (members, messages, files, reports) +- Clean up MinIO storage for associated files +- Broadcast WebSocket disconnect to active connections + +### 2. Hide Archived Rooms from Non-Admin Users +- Modify room listing to exclude ARCHIVED status for non-admin users +- Even "All Status" filter will not show archived rooms for regular users +- Admin users retain full visibility of all room statuses +- Remove "Archived" option from frontend status filter for non-admin users + +## Related Specs +- `chat-room`: Room access control and deletion +- `frontend-core`: Room list filtering UI + +## Out of Scope +- Batch deletion of multiple rooms +- Scheduled auto-deletion of old archived rooms +- Restore deleted rooms from backup diff --git a/openspec/changes/archive/2025-12-05-add-admin-room-management/specs/chat-room/spec.md b/openspec/changes/archive/2025-12-05-add-admin-room-management/specs/chat-room/spec.md new file mode 100644 index 0000000..5ece85d --- /dev/null +++ b/openspec/changes/archive/2025-12-05-add-admin-room-management/specs/chat-room/spec.md @@ -0,0 +1,66 @@ +# chat-room Specification Delta + +## ADDED Requirements + +### Requirement: Admin Permanent Room Deletion +The system SHALL provide system administrators with the ability to permanently delete rooms, including all associated data (members, messages, files, reports). This operation is irreversible and restricted to system administrators only. + +#### Scenario: Admin permanently deletes a room +- **WHEN** a system administrator sends `DELETE /api/rooms/{room_id}/permanent` +- **THEN** the system SHALL verify the user is ymirliu@panjit.com.tw +- **AND** hard delete the room record from incident_rooms table +- **AND** cascade delete all room_members records +- **AND** cascade delete all messages and related reactions/edit_history +- **AND** cascade delete all room_files records +- **AND** delete associated files from MinIO storage +- **AND** cascade delete all generated_reports records +- **AND** delete associated report files from MinIO storage +- **AND** broadcast disconnect event to any active WebSocket connections in the room +- **AND** return status 200 with `{"message": "Room permanently deleted"}` + +#### Scenario: Non-admin attempts permanent deletion +- **WHEN** a non-admin user sends `DELETE /api/rooms/{room_id}/permanent` +- **THEN** the system SHALL return status 403 with "Only system administrators can permanently delete rooms" + +#### Scenario: Permanent delete non-existent room +- **WHEN** a system administrator sends `DELETE /api/rooms/{room_id}/permanent` for a non-existent room +- **THEN** the system SHALL return status 404 with "Room not found" + +### Requirement: Hide Archived Rooms from Non-Admin Users +The system SHALL hide rooms with ARCHIVED status from non-admin users in all listing operations, ensuring historical/archived data is only visible to system administrators. + +#### Scenario: Non-admin lists rooms with any filter +- **WHEN** a non-admin user sends `GET /api/rooms` with any status filter (including no filter) +- **THEN** the system SHALL exclude all rooms with status "archived" from the response +- **AND** only return rooms with status "active" or "resolved" + +#### Scenario: Non-admin explicitly requests archived rooms +- **WHEN** a non-admin user sends `GET /api/rooms?status=archived` +- **THEN** the system SHALL return an empty list +- **AND** return total count of 0 + +#### Scenario: Admin can view archived rooms +- **WHEN** a system administrator sends `GET /api/rooms?status=archived` +- **THEN** the system SHALL return all archived rooms +- **AND** include full room details + +#### Scenario: Admin views all rooms including archived +- **WHEN** a system administrator sends `GET /api/rooms` without status filter +- **THEN** the system SHALL return all rooms regardless of status +- **AND** include archived rooms in the response + +## MODIFIED Requirements + +### Requirement: List and Filter Incident Rooms +The system SHALL provide endpoints to list incident rooms with filtering capabilities by status, incident type, severity, date range, and user membership. The system SHALL automatically exclude rooms with ARCHIVED status from listing results for non-admin users, ensuring archived rooms are only visible to system administrators. + +#### Scenario: List all active rooms for current user +- **WHEN** an authenticated user sends `GET /api/rooms?status=active` +- **THEN** the system SHALL return all active rooms +- **AND** include room metadata (title, type, severity, member count, last activity) +- **AND** sort by last_activity_at descending (most recent first) + +#### Scenario: Non-admin user lists rooms without status filter +- **WHEN** a non-admin user sends `GET /api/rooms` without status parameter +- **THEN** the system SHALL return rooms with status "active" or "resolved" only +- **AND** automatically exclude archived rooms from results diff --git a/openspec/changes/archive/2025-12-05-add-admin-room-management/specs/frontend-core/spec.md b/openspec/changes/archive/2025-12-05-add-admin-room-management/specs/frontend-core/spec.md new file mode 100644 index 0000000..74e58ff --- /dev/null +++ b/openspec/changes/archive/2025-12-05-add-admin-room-management/specs/frontend-core/spec.md @@ -0,0 +1,67 @@ +# frontend-core Specification Delta + +## MODIFIED Requirements + +### Requirement: Incident Room List +The frontend SHALL display a filterable, searchable list of incident rooms accessible to the current user. The frontend SHALL restrict the status filter options to show only "Active" and "Resolved" for non-admin users, and SHALL display all status options including "Archived" only for system administrators. + +#### Scenario: Filter rooms by status (Non-admin) +- **WHEN** a non-admin user views the status filter dropdown +- **THEN** the system SHALL: + - Display only "Active" and "Resolved" options + - NOT display "Archived" option + - NOT display "All Status" option that would include archived rooms + +#### Scenario: Filter rooms by status (Admin) +- **WHEN** a system administrator views the status filter dropdown +- **THEN** the system SHALL: + - Display all status options: "All Status", "Active", "Resolved", "Archived" + - Allow viewing archived rooms + +#### Scenario: Default status filter +- **WHEN** a user navigates to the room list page +- **THEN** the system SHALL: + - Default to "Active" status filter for all users + - Fetch only active rooms initially + +## ADDED Requirements + +### Requirement: Admin Room Deletion Interface +The frontend SHALL provide system administrators with the ability to permanently delete rooms through a dedicated UI control. + +#### Scenario: Display delete button for admin +- **WHEN** a system administrator views a room detail page +- **THEN** the system SHALL: + - Display a "Delete Room Permanently" button in room settings/actions + - Style the button with warning color (red) + - Only show this button to admin users + +#### Scenario: Hide delete button for non-admin +- **WHEN** a non-admin user views a room detail page +- **THEN** the system SHALL: + - NOT display permanent delete option + - Only show standard archive option (if owner) + +#### Scenario: Confirm permanent deletion +- **WHEN** an admin clicks "Delete Room Permanently" +- **THEN** the system SHALL: + - Display a confirmation dialog with warning text + - Require typing room name to confirm (optional safety measure) + - Explain that deletion is irreversible + - Show what will be deleted (messages, files, reports) + +#### Scenario: Execute permanent deletion +- **WHEN** an admin confirms permanent deletion +- **THEN** the system SHALL: + - Send DELETE request to `/api/rooms/{room_id}/permanent` + - Show loading state during deletion + - Navigate to room list on success + - Show success toast message + - Show error message on failure + +#### Scenario: Handle active users in deleted room +- **WHEN** a room is permanently deleted while other users are viewing it +- **THEN** the system SHALL: + - Receive WebSocket disconnect event + - Display "Room has been deleted" message + - Navigate affected users to room list diff --git a/openspec/changes/archive/2025-12-05-add-admin-room-management/tasks.md b/openspec/changes/archive/2025-12-05-add-admin-room-management/tasks.md new file mode 100644 index 0000000..de969d8 --- /dev/null +++ b/openspec/changes/archive/2025-12-05-add-admin-room-management/tasks.md @@ -0,0 +1,89 @@ +# Tasks: Add Admin Room Management + +## Phase 1: Backend - Hide Archived Rooms + +### 1.1 Modify room listing to exclude archived for non-admin +- [x] Update `room_service.list_user_rooms()` to filter out ARCHIVED status for non-admin +- [x] Ensure admin users can still see all statuses +- [x] Handle case where non-admin explicitly requests `status=archived` (return empty) +- [x] Write unit tests for filtered listing behavior + +### 1.2 Update room count queries +- [x] Ensure total count excludes archived for non-admin +- [x] Verify pagination works correctly with filtered results + +## Phase 2: Backend - Permanent Deletion + +### 2.1 Fix room_files foreign key constraint +- [x] Add `ondelete="CASCADE"` to room_files.room_id foreign key +- [x] Create database migration or rebuild schema + +### 2.2 Create permanent delete service method +- [x] Add `permanent_delete_room()` method to room_service +- [x] Implement cascading delete for all related tables +- [x] Add MinIO file cleanup logic +- [x] Handle WebSocket broadcast for room deletion event + +### 2.3 Create permanent delete endpoint +- [x] Add `DELETE /api/rooms/{room_id}/permanent` endpoint +- [x] Implement admin-only authorization check +- [x] Return appropriate error responses (403 for non-admin, 404 for not found) +- [x] Write integration tests + +## Phase 3: Frontend - Status Filter Changes + +### 3.1 Add admin detection to frontend +- [x] Create utility to check if current user is admin +- [x] Store admin status in auth store or derive from username + +### 3.2 Update room list status filter +- [x] Conditionally render filter options based on admin status +- [x] Remove "All Status" and "Archived" for non-admin users +- [x] Keep default filter as "Active" +- [x] Test filter behavior for both user types + +## Phase 4: Frontend - Permanent Delete UI + +### 4.1 Add delete button to room detail +- [x] Create "Delete Room Permanently" button (admin only) +- [x] Style with warning/danger color scheme +- [x] Position in room settings or header actions + +### 4.2 Implement confirmation dialog +- [x] Create confirmation modal with warning text +- [x] List what will be deleted (members, messages, files, reports) +- [x] Add optional room name confirmation input +- [x] Implement cancel and confirm buttons + +### 4.3 Handle deletion flow +- [x] Call DELETE `/api/rooms/{room_id}/permanent` on confirm +- [x] Show loading state during deletion +- [x] Navigate to room list on success +- [x] Display error toast on failure + +### 4.4 Handle WebSocket room deletion event +- [x] Listen for room_deleted event in WebSocket handler +- [x] Display notification to affected users +- [x] Navigate users away from deleted room + +## Phase 5: Testing & Validation + +### 5.1 Backend tests +- [x] Test non-admin cannot see archived rooms +- [x] Test admin can see all rooms including archived +- [x] Test permanent delete endpoint authorization +- [x] Test cascading delete removes all related data +- [x] Test MinIO cleanup on permanent delete + +### 5.2 Frontend tests +- [x] Test status filter options for admin vs non-admin +- [x] Test delete button visibility +- [x] Test confirmation dialog flow +- [x] Test WebSocket room deletion handling + +## Validation Checklist +- [x] Run `openspec validate add-admin-room-management --strict` +- [x] All existing tests pass +- [x] New tests cover all scenarios +- [x] Manual testing of full admin flow +- [x] Manual testing of non-admin restrictions diff --git a/openspec/changes/archive/add-mobile-responsive-layout/proposal.md b/openspec/changes/archive/add-mobile-responsive-layout/proposal.md new file mode 100644 index 0000000..4c8f444 --- /dev/null +++ b/openspec/changes/archive/add-mobile-responsive-layout/proposal.md @@ -0,0 +1,64 @@ +# Proposal: Add Mobile Responsive Layout + +## Summary +Add device detection and responsive layout switching to optimize the user experience on mobile devices (<768px). The frontend currently only supports desktop and tablet layouts, leaving mobile users with horizontal scrolling issues and poor usability. + +## Motivation +- **Fixed sidebar widths** (w-72 for members, w-80 for files) cause horizontal overflow on mobile screens +- **Header controls** don't adapt to narrow screens, causing button wrapping issues +- **No mobile navigation pattern** - current horizontal nav doesn't collapse +- **Small touch targets** - buttons use px-3 py-1.5 which is difficult to tap on mobile +- Mobile devices are commonly used on the production floor for quick incident reporting + +## Scope + +### In Scope +1. **Device Detection Hook** (`useIsMobile`) - Detect mobile vs desktop using media queries +2. **Collapsible Sidebars** - Transform fixed sidebars into slide-in panels on mobile +3. **Mobile Header** - Simplified header with hamburger menu or action sheet +4. **Bottom Toolbar** - Move frequently used actions to bottom of screen for thumb-friendly access +5. **Touch-Friendly Sizing** - Increase button/input sizes on mobile +6. **Responsive Text** - Adjust font sizes for readability on small screens + +### Out of Scope +- Native mobile app (PWA can be considered later) +- Offline functionality +- Push notifications +- Complex gestures (swipe to delete, etc.) + +## Technical Approach + +### Device Detection +```typescript +// hooks/useMediaQuery.ts +export function useIsMobile(): boolean { + return useMediaQuery('(max-width: 767px)') +} + +export function useIsTablet(): boolean { + return useMediaQuery('(min-width: 768px) and (max-width: 1023px)') +} +``` + +### Layout Strategy +- **Mobile (<768px)**: Single-column layout, slide-in sidebars, bottom action bar +- **Tablet (768-1023px)**: Current behavior with minor adjustments +- **Desktop (>1024px)**: Current behavior (unchanged) + +### Key Component Changes + +| Component | Mobile Behavior | +|-----------|----------------| +| RoomDetail Header | Collapse to hamburger menu, show essential actions only | +| Members Sidebar | Slide-in from right, full-screen overlay | +| Files Sidebar | Slide-in from right, full-screen overlay | +| Message Input | Sticky bottom with larger touch targets | +| Room Cards | Full-width single column | + +## Impact +- **frontend-core** spec: Add mobile-specific requirements to "Responsive Layout and Navigation" +- Estimated file changes: ~8 frontend files +- No backend changes required + +## Related Changes +- None (standalone improvement) diff --git a/openspec/changes/archive/add-mobile-responsive-layout/specs/mobile-layout/spec.md b/openspec/changes/archive/add-mobile-responsive-layout/specs/mobile-layout/spec.md new file mode 100644 index 0000000..03ed49e --- /dev/null +++ b/openspec/changes/archive/add-mobile-responsive-layout/specs/mobile-layout/spec.md @@ -0,0 +1,132 @@ +# mobile-layout Specification + +## Purpose +Provide responsive layout capabilities that detect user devices and adapt the UI for optimal mobile experience. This extends the existing "Responsive Layout and Navigation" requirement in frontend-core to include mobile devices (<768px). + +## MODIFIED Requirements + +### Requirement: Responsive Layout and Navigation +The frontend SHALL provide a responsive layout that works on desktop, tablet, and **mobile** devices with intuitive navigation. The system SHALL detect the device type and switch layouts accordingly. + +#### Scenario: Mobile layout (<768px) +- **WHEN** viewed on mobile devices (<768px width) +- **THEN** the system SHALL: + - Display a simplified header with hamburger menu + - Show sidebars as full-screen slide-in panels (not inline) + - Display a bottom toolbar with frequently used actions + - Use single-column layout for content + - Ensure all touch targets are at least 44x44 pixels + +#### Scenario: Tablet layout (768px-1024px) +- **WHEN** viewed on tablet (768px-1024px) +- **THEN** the system SHALL: + - Collapse sidebars to icons or overlay panels + - Use full width for content areas + - Stack panels vertically when needed + +#### Scenario: Desktop layout (>1024px) +- **WHEN** viewed on desktop (>1024px) +- **THEN** the system SHALL: + - Display full navigation and sidebars inline + - Show room list and detail side-by-side when applicable + - Display member/file panels as sidebars + +## ADDED Requirements + +### Requirement: Device Detection +The frontend SHALL provide hooks for detecting device type based on viewport width. + +#### Scenario: Detect mobile device +- **WHEN** the viewport width is less than 768px +- **THEN** `useIsMobile()` hook SHALL return `true` +- **AND** the UI SHALL render mobile-optimized components + +#### Scenario: Detect tablet device +- **WHEN** the viewport width is between 768px and 1023px +- **THEN** `useIsTablet()` hook SHALL return `true` + +#### Scenario: Detect desktop device +- **WHEN** the viewport width is 1024px or greater +- **THEN** `useIsDesktop()` hook SHALL return `true` + +#### Scenario: Handle viewport resize +- **WHEN** the user resizes the browser window across breakpoints +- **THEN** the hooks SHALL update their return values +- **AND** the UI SHALL transition smoothly to the appropriate layout + +### Requirement: Mobile Navigation +The frontend SHALL provide mobile-optimized navigation patterns for small screens. + +#### Scenario: Display mobile header +- **WHEN** on mobile layout in room detail view +- **THEN** the system SHALL: + - Show room title (truncated if necessary) + - Show connection status indicator + - Show hamburger menu button + - Hide secondary action buttons (move to menu) + +#### Scenario: Open mobile action menu +- **WHEN** user taps the hamburger menu on mobile +- **THEN** the system SHALL: + - Display an action drawer/sheet from bottom or side + - Show all room actions: Generate Report, Change Status, etc. + - Allow closing by tapping outside or swipe gesture + +#### Scenario: Display bottom toolbar +- **WHEN** on mobile layout in room detail view +- **THEN** the system SHALL: + - Show a fixed bottom toolbar above the message input + - Include buttons for: Files, Members + - Use icons with labels for clarity + - Ensure toolbar doesn't overlap with device safe areas + +### Requirement: Mobile Sidebars +The frontend SHALL display sidebars as slide-in panels on mobile devices. + +#### Scenario: Open members panel on mobile +- **WHEN** user taps the Members button on mobile +- **THEN** the system SHALL: + - Slide in a full-screen panel from the right + - Display dark overlay behind the panel + - Show member list with larger touch targets + - Include a close button at the top of the panel + +#### Scenario: Close sidebar panel +- **WHEN** user taps the close button or backdrop overlay +- **THEN** the system SHALL: + - Slide the panel out to the right + - Remove the dark overlay + - Return focus to the main content + +#### Scenario: Open files panel on mobile +- **WHEN** user taps the Files button on mobile +- **THEN** the system SHALL: + - Slide in a full-screen panel from the right + - Display file list with larger thumbnails + - Show upload area with larger drop zone + - Include a close button at the top + +### Requirement: Touch-Friendly Interactions +The frontend SHALL ensure all interactive elements are usable on touch devices. + +#### Scenario: Minimum touch target size +- **WHEN** displaying buttons, links, or interactive elements on mobile +- **THEN** the system SHALL: + - Ensure minimum touch target of 44x44 pixels + - Provide adequate spacing between touch targets + - Use padding to expand touch areas without changing visual size + +#### Scenario: Mobile message input +- **WHEN** user focuses the message input on mobile +- **THEN** the system SHALL: + - Expand input area for easier typing + - Keep send button easily accessible + - Handle soft keyboard appearance gracefully + - Not obscure the input behind the keyboard + +#### Scenario: Mobile form inputs +- **WHEN** displaying form inputs on mobile (login, add member, etc.) +- **THEN** the system SHALL: + - Use larger input fields (minimum height 44px) + - Show appropriate mobile keyboard type (email, text, etc.) + - Support autocomplete where appropriate diff --git a/openspec/changes/archive/add-mobile-responsive-layout/tasks.md b/openspec/changes/archive/add-mobile-responsive-layout/tasks.md new file mode 100644 index 0000000..53e2314 --- /dev/null +++ b/openspec/changes/archive/add-mobile-responsive-layout/tasks.md @@ -0,0 +1,98 @@ +# Tasks: Add Mobile Responsive Layout + +## Phase 1: Foundation - Device Detection + +- [x] **T-1.1**: Create `useMediaQuery` hook for responsive breakpoint detection + - Create `/frontend/src/hooks/useMediaQuery.ts` + - Export `useMediaQuery`, `useIsMobile`, `useIsTablet`, `useIsDesktop` + - Add unit tests for hook behavior + +- [x] **T-1.2**: Add mobile viewport meta and CSS custom properties + - Ensure viewport meta tag is properly configured + - Add CSS custom properties for safe area insets (notch handling) + +## Phase 2: Mobile Navigation & Header + +- [x] **T-2.1**: Create `MobileHeader` component with hamburger menu + - Show essential info: room title, status, connection indicator + - Hamburger button triggers action drawer + - Implement slide-in action drawer for secondary actions + +- [x] **T-2.2**: Create `BottomToolbar` component for mobile + - Show: Files toggle, Members toggle, Message input trigger + - Fixed position at bottom, above keyboard when active + - Touch-friendly button sizes (min 44x44px) + +- [x] **T-2.3**: Update `RoomDetail` header to switch between desktop and mobile layouts + - Use `useIsMobile()` to conditionally render + - Desktop: Current header layout + - Mobile: `MobileHeader` + `BottomToolbar` + +## Phase 3: Collapsible Sidebars + +- [x] **T-3.1**: Create `SlidePanel` component for mobile sidebars + - Full-height slide-in from right + - Dark overlay backdrop + - Close on backdrop click or swipe + - Smooth CSS transitions + +- [x] **T-3.2**: Update Members sidebar to use `SlidePanel` on mobile + - Wrap existing member list content + - Add close button at top + - Full-screen width on mobile + +- [x] **T-3.3**: Update Files sidebar to use `SlidePanel` on mobile + - Wrap existing file list and upload area + - Larger upload drop zone on mobile + - Full-screen width on mobile + +## Phase 4: Room List Mobile Optimization + +- [x] **T-4.1**: Update `RoomList` layout for mobile + - Full-width room cards (remove grid on mobile) + - Stack filter controls vertically + - Increase touch targets on filter buttons + +- [x] **T-4.2**: Add mobile-optimized room card design + - Larger status/severity badges + - More padding for touch targets + - Truncate long descriptions + +## Phase 5: Touch-Friendly Inputs + +- [x] **T-5.1**: Update message input for mobile + - Larger input field (min height 44px) + - Larger send button + - Handle keyboard appearance gracefully + +- [x] **T-5.2**: Update button and input sizes globally on mobile + - Minimum touch target 44x44px + - Larger form inputs + - Use Tailwind responsive variants (sm: prefixes) + +## Phase 6: Testing & Validation + +- [x] **T-6.1**: Add responsive tests for key components + - Test `useMediaQuery` hook with different window sizes + - Test component rendering at mobile breakpoint + - Test sidebar open/close behavior + +- [x] **T-6.2**: Manual testing on actual devices + - Test on iPhone Safari + - Test on Android Chrome + - Test keyboard interactions + - Test safe area handling (notch) + +- [x] **T-6.3**: Run full test suite and fix any regressions + - `npm run test:run` + - `npm run build` + - Fix any TypeScript or lint errors + +## Dependencies +- T-1.1 must complete before T-2.x and T-3.x +- T-3.1 must complete before T-3.2 and T-3.3 +- T-6.x depends on all other tasks + +## Parallelizable Work +- T-2.x (Navigation) and T-3.x (Sidebars) can run in parallel after T-1.1 +- T-4.x (Room List) can run in parallel with T-2.x and T-3.x diff --git a/openspec/specs/chat-room/spec.md b/openspec/specs/chat-room/spec.md index aa5ab8e..b278447 100644 --- a/openspec/specs/chat-room/spec.md +++ b/openspec/specs/chat-room/spec.md @@ -52,23 +52,18 @@ The system SHALL allow authenticated users to create a new incident room with me - **THEN** the system SHALL return status 401 with "Authentication required" ### Requirement: List and Filter Incident Rooms -The system SHALL provide endpoints to list incident rooms with filtering capabilities by status, incident type, severity, date range, and user membership. +The system SHALL provide endpoints to list incident rooms with filtering capabilities by status, incident type, severity, date range, and user membership. The system SHALL automatically exclude rooms with ARCHIVED status from listing results for non-admin users, ensuring archived rooms are only visible to system administrators. #### Scenario: List all active rooms for current user - **WHEN** an authenticated user sends `GET /api/rooms?status=active` -- **THEN** the system SHALL return all active rooms where the user is a member +- **THEN** the system SHALL return all active rooms - **AND** include room metadata (title, type, severity, member count, last activity) - **AND** sort by last_activity_at descending (most recent first) -#### Scenario: Filter rooms by incident type and date range -- **WHEN** a user sends `GET /api/rooms?incident_type=quality_issue&created_after=2025-01-01&created_before=2025-01-31` -- **THEN** the system SHALL return rooms matching ALL filter criteria -- **AND** only include rooms where the user is a member - -#### Scenario: Search rooms by title or description -- **WHEN** a user sends `GET /api/rooms?search=conveyor` -- **THEN** the system SHALL return rooms where title OR description contains "conveyor" (case-insensitive) -- **AND** highlight matching terms in the response +#### Scenario: Non-admin user lists rooms without status filter +- **WHEN** a non-admin user sends `GET /api/rooms` without status parameter +- **THEN** the system SHALL return rooms with status "active" or "resolved" only +- **AND** automatically exclude archived rooms from results ### Requirement: Manage Room Membership The system SHALL allow room owners and members with appropriate permissions to add or remove members and assign roles (owner, editor, viewer). Room owners SHALL be able to transfer ownership to another member. System administrators SHALL have override capabilities for all membership operations. @@ -218,3 +213,50 @@ The system SHALL support predefined room templates for common incident types to - Default values for each template - Required additional fields +### Requirement: Admin Permanent Room Deletion +The system SHALL provide system administrators with the ability to permanently delete rooms, including all associated data (members, messages, files, reports). This operation is irreversible and restricted to system administrators only. + +#### Scenario: Admin permanently deletes a room +- **WHEN** a system administrator sends `DELETE /api/rooms/{room_id}/permanent` +- **THEN** the system SHALL verify the user is ymirliu@panjit.com.tw +- **AND** hard delete the room record from incident_rooms table +- **AND** cascade delete all room_members records +- **AND** cascade delete all messages and related reactions/edit_history +- **AND** cascade delete all room_files records +- **AND** delete associated files from MinIO storage +- **AND** cascade delete all generated_reports records +- **AND** delete associated report files from MinIO storage +- **AND** broadcast disconnect event to any active WebSocket connections in the room +- **AND** return status 200 with `{"message": "Room permanently deleted"}` + +#### Scenario: Non-admin attempts permanent deletion +- **WHEN** a non-admin user sends `DELETE /api/rooms/{room_id}/permanent` +- **THEN** the system SHALL return status 403 with "Only system administrators can permanently delete rooms" + +#### Scenario: Permanent delete non-existent room +- **WHEN** a system administrator sends `DELETE /api/rooms/{room_id}/permanent` for a non-existent room +- **THEN** the system SHALL return status 404 with "Room not found" + +### Requirement: Hide Archived Rooms from Non-Admin Users +The system SHALL hide rooms with ARCHIVED status from non-admin users in all listing operations, ensuring historical/archived data is only visible to system administrators. + +#### Scenario: Non-admin lists rooms with any filter +- **WHEN** a non-admin user sends `GET /api/rooms` with any status filter (including no filter) +- **THEN** the system SHALL exclude all rooms with status "archived" from the response +- **AND** only return rooms with status "active" or "resolved" + +#### Scenario: Non-admin explicitly requests archived rooms +- **WHEN** a non-admin user sends `GET /api/rooms?status=archived` +- **THEN** the system SHALL return an empty list +- **AND** return total count of 0 + +#### Scenario: Admin can view archived rooms +- **WHEN** a system administrator sends `GET /api/rooms?status=archived` +- **THEN** the system SHALL return all archived rooms +- **AND** include full room details + +#### Scenario: Admin views all rooms including archived +- **WHEN** a system administrator sends `GET /api/rooms` without status filter +- **THEN** the system SHALL return all rooms regardless of status +- **AND** include archived rooms in the response + diff --git a/openspec/specs/frontend-core/spec.md b/openspec/specs/frontend-core/spec.md index 623a10b..72d4ad9 100644 --- a/openspec/specs/frontend-core/spec.md +++ b/openspec/specs/frontend-core/spec.md @@ -36,35 +36,26 @@ The frontend SHALL provide a login interface that authenticates users against th - Redirect to login page ### Requirement: Incident Room List -The frontend SHALL display a filterable, searchable list of incident rooms accessible to the current user. +The frontend SHALL display a filterable, searchable list of incident rooms accessible to the current user. The frontend SHALL restrict the status filter options to show only "Active" and "Resolved" for non-admin users, and SHALL display all status options including "Archived" only for system administrators. -#### Scenario: Display room list -- **WHEN** a logged-in user navigates to the room list page +#### Scenario: Filter rooms by status (Non-admin) +- **WHEN** a non-admin user views the status filter dropdown - **THEN** the system SHALL: - - Fetch rooms from `GET /api/rooms` - - Display rooms as cards with title, status, severity, and timestamp - - Show the user's role in each room - - Order by last activity (most recent first) + - Display only "Active" and "Resolved" options + - NOT display "Archived" option + - NOT display "All Status" option that would include archived rooms -#### Scenario: Filter rooms by status -- **WHEN** a user selects a status filter (Active, Resolved, Archived) +#### Scenario: Filter rooms by status (Admin) +- **WHEN** a system administrator views the status filter dropdown - **THEN** the system SHALL: - - Update the room list to show only rooms matching the filter - - Preserve other active filters + - Display all status options: "All Status", "Active", "Resolved", "Archived" + - Allow viewing archived rooms -#### Scenario: Search rooms -- **WHEN** a user enters text in the search box +#### Scenario: Default status filter +- **WHEN** a user navigates to the room list page - **THEN** the system SHALL: - - Filter rooms by title and description containing the search text - - Update results in real-time (debounced) - -#### Scenario: Create new room -- **WHEN** a user clicks "New Room" and fills the creation form -- **THEN** the system SHALL: - - Display template selection if templates exist - - Submit room creation to `POST /api/rooms` - - Navigate to the new room on success - - Show error message on failure + - Default to "Active" status filter for all users + - Fetch only active rooms initially ### Requirement: Incident Room Detail View The frontend SHALL display complete incident room information including metadata, members, and provide management controls for authorized users. @@ -270,3 +261,43 @@ The frontend SHALL provide a responsive layout that works on desktop and tablet - Log error details for debugging - Not crash or show blank screen +### Requirement: Admin Room Deletion Interface +The frontend SHALL provide system administrators with the ability to permanently delete rooms through a dedicated UI control. + +#### Scenario: Display delete button for admin +- **WHEN** a system administrator views a room detail page +- **THEN** the system SHALL: + - Display a "Delete Room Permanently" button in room settings/actions + - Style the button with warning color (red) + - Only show this button to admin users + +#### Scenario: Hide delete button for non-admin +- **WHEN** a non-admin user views a room detail page +- **THEN** the system SHALL: + - NOT display permanent delete option + - Only show standard archive option (if owner) + +#### Scenario: Confirm permanent deletion +- **WHEN** an admin clicks "Delete Room Permanently" +- **THEN** the system SHALL: + - Display a confirmation dialog with warning text + - Require typing room name to confirm (optional safety measure) + - Explain that deletion is irreversible + - Show what will be deleted (messages, files, reports) + +#### Scenario: Execute permanent deletion +- **WHEN** an admin confirms permanent deletion +- **THEN** the system SHALL: + - Send DELETE request to `/api/rooms/{room_id}/permanent` + - Show loading state during deletion + - Navigate to room list on success + - Show success toast message + - Show error message on failure + +#### Scenario: Handle active users in deleted room +- **WHEN** a room is permanently deleted while other users are viewing it +- **THEN** the system SHALL: + - Receive WebSocket disconnect event + - Display "Room has been deleted" message + - Navigate affected users to room list + diff --git a/openspec/specs/mobile-layout/spec.md b/openspec/specs/mobile-layout/spec.md new file mode 100644 index 0000000..03ed49e --- /dev/null +++ b/openspec/specs/mobile-layout/spec.md @@ -0,0 +1,132 @@ +# mobile-layout Specification + +## Purpose +Provide responsive layout capabilities that detect user devices and adapt the UI for optimal mobile experience. This extends the existing "Responsive Layout and Navigation" requirement in frontend-core to include mobile devices (<768px). + +## MODIFIED Requirements + +### Requirement: Responsive Layout and Navigation +The frontend SHALL provide a responsive layout that works on desktop, tablet, and **mobile** devices with intuitive navigation. The system SHALL detect the device type and switch layouts accordingly. + +#### Scenario: Mobile layout (<768px) +- **WHEN** viewed on mobile devices (<768px width) +- **THEN** the system SHALL: + - Display a simplified header with hamburger menu + - Show sidebars as full-screen slide-in panels (not inline) + - Display a bottom toolbar with frequently used actions + - Use single-column layout for content + - Ensure all touch targets are at least 44x44 pixels + +#### Scenario: Tablet layout (768px-1024px) +- **WHEN** viewed on tablet (768px-1024px) +- **THEN** the system SHALL: + - Collapse sidebars to icons or overlay panels + - Use full width for content areas + - Stack panels vertically when needed + +#### Scenario: Desktop layout (>1024px) +- **WHEN** viewed on desktop (>1024px) +- **THEN** the system SHALL: + - Display full navigation and sidebars inline + - Show room list and detail side-by-side when applicable + - Display member/file panels as sidebars + +## ADDED Requirements + +### Requirement: Device Detection +The frontend SHALL provide hooks for detecting device type based on viewport width. + +#### Scenario: Detect mobile device +- **WHEN** the viewport width is less than 768px +- **THEN** `useIsMobile()` hook SHALL return `true` +- **AND** the UI SHALL render mobile-optimized components + +#### Scenario: Detect tablet device +- **WHEN** the viewport width is between 768px and 1023px +- **THEN** `useIsTablet()` hook SHALL return `true` + +#### Scenario: Detect desktop device +- **WHEN** the viewport width is 1024px or greater +- **THEN** `useIsDesktop()` hook SHALL return `true` + +#### Scenario: Handle viewport resize +- **WHEN** the user resizes the browser window across breakpoints +- **THEN** the hooks SHALL update their return values +- **AND** the UI SHALL transition smoothly to the appropriate layout + +### Requirement: Mobile Navigation +The frontend SHALL provide mobile-optimized navigation patterns for small screens. + +#### Scenario: Display mobile header +- **WHEN** on mobile layout in room detail view +- **THEN** the system SHALL: + - Show room title (truncated if necessary) + - Show connection status indicator + - Show hamburger menu button + - Hide secondary action buttons (move to menu) + +#### Scenario: Open mobile action menu +- **WHEN** user taps the hamburger menu on mobile +- **THEN** the system SHALL: + - Display an action drawer/sheet from bottom or side + - Show all room actions: Generate Report, Change Status, etc. + - Allow closing by tapping outside or swipe gesture + +#### Scenario: Display bottom toolbar +- **WHEN** on mobile layout in room detail view +- **THEN** the system SHALL: + - Show a fixed bottom toolbar above the message input + - Include buttons for: Files, Members + - Use icons with labels for clarity + - Ensure toolbar doesn't overlap with device safe areas + +### Requirement: Mobile Sidebars +The frontend SHALL display sidebars as slide-in panels on mobile devices. + +#### Scenario: Open members panel on mobile +- **WHEN** user taps the Members button on mobile +- **THEN** the system SHALL: + - Slide in a full-screen panel from the right + - Display dark overlay behind the panel + - Show member list with larger touch targets + - Include a close button at the top of the panel + +#### Scenario: Close sidebar panel +- **WHEN** user taps the close button or backdrop overlay +- **THEN** the system SHALL: + - Slide the panel out to the right + - Remove the dark overlay + - Return focus to the main content + +#### Scenario: Open files panel on mobile +- **WHEN** user taps the Files button on mobile +- **THEN** the system SHALL: + - Slide in a full-screen panel from the right + - Display file list with larger thumbnails + - Show upload area with larger drop zone + - Include a close button at the top + +### Requirement: Touch-Friendly Interactions +The frontend SHALL ensure all interactive elements are usable on touch devices. + +#### Scenario: Minimum touch target size +- **WHEN** displaying buttons, links, or interactive elements on mobile +- **THEN** the system SHALL: + - Ensure minimum touch target of 44x44 pixels + - Provide adequate spacing between touch targets + - Use padding to expand touch areas without changing visual size + +#### Scenario: Mobile message input +- **WHEN** user focuses the message input on mobile +- **THEN** the system SHALL: + - Expand input area for easier typing + - Keep send button easily accessible + - Handle soft keyboard appearance gracefully + - Not obscure the input behind the keyboard + +#### Scenario: Mobile form inputs +- **WHEN** displaying form inputs on mobile (login, add member, etc.) +- **THEN** the system SHALL: + - Use larger input fields (minimum height 44px) + - Show appropriate mobile keyboard type (email, text, etc.) + - Support autocomplete where appropriate diff --git a/stop-dev.sh b/stop-dev.sh index e765c4f..5810456 100755 --- a/stop-dev.sh +++ b/stop-dev.sh @@ -168,6 +168,67 @@ else print_info "Keeping MinIO running (--keep-minio)" fi +# ============================================================================ +# Port Release +# ============================================================================ +print_header "Port Release" + +# Function to release port +release_port() { + local port=$1 + local service_name=$2 + + # Check if port is in use + if command -v fuser &> /dev/null; then + # Use fuser if available + if fuser "$port/tcp" > /dev/null 2>&1; then + print_info "Releasing port $port ($service_name)..." + fuser -k "$port/tcp" > /dev/null 2>&1 || true + sleep 1 + if ! fuser "$port/tcp" > /dev/null 2>&1; then + print_ok "Port $port released" + else + print_warn "Port $port may still be in use (TIME_WAIT state)" + fi + else + print_ok "Port $port is free" + fi + elif command -v lsof &> /dev/null; then + # Fallback to lsof + local pid=$(lsof -ti ":$port" 2>/dev/null | head -1) + if [[ -n "$pid" ]]; then + print_info "Releasing port $port ($service_name, PID: $pid)..." + kill "$pid" 2>/dev/null || true + sleep 1 + if ! lsof -ti ":$port" > /dev/null 2>&1; then + print_ok "Port $port released" + else + # Force kill if still in use + kill -9 "$pid" 2>/dev/null || true + sleep 1 + if ! lsof -ti ":$port" > /dev/null 2>&1; then + print_ok "Port $port force released" + else + print_warn "Port $port may still be in use (TIME_WAIT state)" + fi + fi + else + print_ok "Port $port is free" + fi + else + # Check with netstat/ss as last resort + if ss -tuln 2>/dev/null | grep -q ":$port "; then + print_warn "Port $port appears in use but no tool to release it" + else + print_ok "Port $port is free" + fi + fi +} + +# Release application ports (not MinIO ports - those are managed by Docker) +release_port 8000 "Backend API" +release_port 3000 "Frontend" + # ============================================================================ # Cleanup # ============================================================================