Files
Task_Reporter/app/modules/chat_room/services/room_service.py
egg 44822a561a feat: Improve file display, timezone handling, and LOT management
Changes:
- Fix datetime serialization with UTC 'Z' suffix for correct timezone display
- Add PDF upload support with extension fallback for MIME detection
- Fix LOT add/remove by creating new list for SQLAlchemy JSON change detection
- Add file message components (FileMessage, ImageLightbox, UploadPreview)
- Add multi-file upload support with progress tracking
- Link uploaded files to chat messages via message_id
- Include file attachments in AI report generation
- Update specs for file-storage, realtime-messaging, and ai-report-generation

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
2025-12-08 12:39:15 +08:00

488 lines
14 KiB
Python

"""Room service for managing incident rooms
Handles business logic for room CRUD operations
"""
from sqlalchemy.orm import Session
from sqlalchemy import or_, and_, func
from typing import List, Optional, Dict, Tuple
from datetime import datetime
import uuid
import logging
from app.modules.chat_room.models import IncidentRoom, RoomMember, RoomStatus, MemberRole
from app.modules.chat_room.schemas import CreateRoomRequest, UpdateRoomRequest, RoomFilterParams
logger = logging.getLogger(__name__)
class RoomService:
"""Service for room management operations"""
def create_room(
self,
db: Session,
user_id: str,
room_data: CreateRoomRequest
) -> IncidentRoom:
"""Create a new incident room
Args:
db: Database session
user_id: ID of user creating the room
room_data: Room creation data
Returns:
Created room instance
"""
# Create room
room = IncidentRoom(
room_id=str(uuid.uuid4()),
title=room_data.title,
incident_type=room_data.incident_type,
severity=room_data.severity,
location=room_data.location,
description=room_data.description,
lots=room_data.lots or [],
status=RoomStatus.ACTIVE,
created_by=user_id,
created_at=datetime.utcnow(),
last_activity_at=datetime.utcnow(),
last_updated_at=datetime.utcnow(),
member_count=1
)
db.add(room)
# Add creator as owner
owner = RoomMember(
room_id=room.room_id,
user_id=user_id,
role=MemberRole.OWNER,
added_by=user_id,
added_at=datetime.utcnow()
)
db.add(owner)
db.commit()
db.refresh(room)
return room
def get_room(
self,
db: Session,
room_id: str,
user_id: str,
is_admin: bool = False
) -> Optional[IncidentRoom]:
"""Get room details
Args:
db: Database session
room_id: Room ID
user_id: User requesting access
is_admin: Whether user is system admin
Returns:
Room instance if user has access, None otherwise
"""
room = db.query(IncidentRoom).filter(
IncidentRoom.room_id == room_id
).first()
if not room:
return None
# Check access: admin or member
if not is_admin:
member = db.query(RoomMember).filter(
and_(
RoomMember.room_id == room_id,
RoomMember.user_id == user_id,
RoomMember.removed_at.is_(None)
)
).first()
if not member:
return None
return room
def list_user_rooms(
self,
db: Session,
user_id: str,
filters: RoomFilterParams,
is_admin: bool = False
) -> List[IncidentRoom]:
"""List rooms accessible to user with filters
All authenticated users can see all rooms by default.
Use my_rooms=true to filter to only rooms where user is a member.
Non-admin users cannot see ARCHIVED rooms.
Args:
db: Database session
user_id: User ID
filters: Filter parameters
is_admin: Whether user is system admin
Returns:
List of rooms and total count
"""
# Non-admin requesting archived rooms explicitly - return empty
if not is_admin and filters.status == RoomStatus.ARCHIVED:
return [], 0
query = db.query(IncidentRoom)
# Filter to user's rooms only if my_rooms=true
if filters.my_rooms:
query = query.join(RoomMember).filter(
and_(
RoomMember.user_id == user_id,
RoomMember.removed_at.is_(None)
)
)
# Hide archived rooms from non-admin users
if not is_admin:
query = query.filter(IncidentRoom.status != RoomStatus.ARCHIVED)
# Apply filters
if filters.status:
query = query.filter(IncidentRoom.status == filters.status)
if filters.incident_type:
query = query.filter(IncidentRoom.incident_type == filters.incident_type)
if filters.severity:
query = query.filter(IncidentRoom.severity == filters.severity)
if filters.created_after:
query = query.filter(IncidentRoom.created_at >= filters.created_after)
if filters.created_before:
query = query.filter(IncidentRoom.created_at <= filters.created_before)
if filters.search:
search_term = f"%{filters.search}%"
query = query.filter(
or_(
IncidentRoom.title.ilike(search_term),
IncidentRoom.description.ilike(search_term)
)
)
# Order by last activity (most recent first)
query = query.order_by(IncidentRoom.last_activity_at.desc())
# Apply pagination
total = query.count()
rooms = query.offset(filters.offset).limit(filters.limit).all()
return rooms, total
def update_room(
self,
db: Session,
room_id: str,
updates: UpdateRoomRequest
) -> Optional[IncidentRoom]:
"""Update room metadata
Args:
db: Database session
room_id: Room ID
updates: Update data
Returns:
Updated room or None if not found
"""
room = db.query(IncidentRoom).filter(
IncidentRoom.room_id == room_id
).first()
if not room:
return None
# Apply updates
if updates.title is not None:
room.title = updates.title
if updates.severity is not None:
room.severity = updates.severity
if updates.location is not None:
room.location = updates.location
if updates.description is not None:
room.description = updates.description
if updates.resolution_notes is not None:
room.resolution_notes = updates.resolution_notes
if updates.lots is not None:
room.lots = updates.lots
# Handle status transitions
if updates.status is not None:
if not self._validate_status_transition(room.status, updates.status):
raise ValueError(f"Invalid status transition from {room.status} to {updates.status}")
room.status = updates.status
# Update timestamps based on status
if updates.status == RoomStatus.RESOLVED:
room.resolved_at = datetime.utcnow()
elif updates.status == RoomStatus.ARCHIVED:
room.archived_at = datetime.utcnow()
# Update activity timestamps
room.last_updated_at = datetime.utcnow()
room.last_activity_at = datetime.utcnow()
db.commit()
db.refresh(room)
return room
def change_room_status(
self,
db: Session,
room_id: str,
new_status: RoomStatus
) -> Optional[IncidentRoom]:
"""Change room status with validation
Args:
db: Database session
room_id: Room ID
new_status: New status
Returns:
Updated room or None
"""
room = db.query(IncidentRoom).filter(
IncidentRoom.room_id == room_id
).first()
if not room:
return None
if not self._validate_status_transition(room.status, new_status):
raise ValueError(f"Invalid status transition from {room.status} to {new_status}")
room.status = new_status
# Update timestamps
if new_status == RoomStatus.RESOLVED:
room.resolved_at = datetime.utcnow()
elif new_status == RoomStatus.ARCHIVED:
room.archived_at = datetime.utcnow()
room.last_updated_at = datetime.utcnow()
room.last_activity_at = datetime.utcnow()
db.commit()
db.refresh(room)
return room
def search_rooms(
self,
db: Session,
user_id: str,
search_term: str,
is_admin: bool = False
) -> List[IncidentRoom]:
"""Search rooms by title or description
Args:
db: Database session
user_id: User ID
search_term: Search string
is_admin: Whether user is system admin
Returns:
List of matching rooms
"""
query = db.query(IncidentRoom)
# Access control
if not is_admin:
query = query.join(RoomMember).filter(
and_(
RoomMember.user_id == user_id,
RoomMember.removed_at.is_(None)
)
)
# Search filter
search_pattern = f"%{search_term}%"
query = query.filter(
or_(
IncidentRoom.title.ilike(search_pattern),
IncidentRoom.description.ilike(search_pattern)
)
)
return query.order_by(IncidentRoom.last_activity_at.desc()).all()
def delete_room(
self,
db: Session,
room_id: str
) -> bool:
"""Soft delete a room (archive it)
Args:
db: Database session
room_id: Room ID
Returns:
True if deleted, False if not found
"""
room = db.query(IncidentRoom).filter(
IncidentRoom.room_id == room_id
).first()
if not room:
return False
room.status = RoomStatus.ARCHIVED
room.archived_at = datetime.utcnow()
room.last_updated_at = datetime.utcnow()
db.commit()
return True
def _validate_status_transition(
self,
current_status: RoomStatus,
new_status: RoomStatus
) -> bool:
"""Validate status transition
Valid transitions:
- active -> resolved
- resolved -> archived
- active -> archived (allowed but not recommended)
Args:
current_status: Current status
new_status: New status
Returns:
True if valid, False otherwise
"""
valid_transitions = {
RoomStatus.ACTIVE: [RoomStatus.RESOLVED, RoomStatus.ARCHIVED],
RoomStatus.RESOLVED: [RoomStatus.ARCHIVED],
RoomStatus.ARCHIVED: [] # No transitions from archived
}
return new_status in valid_transitions.get(current_status, [])
def update_room_activity(
self,
db: Session,
room_id: str
) -> None:
"""Update room's last activity timestamp
Args:
db: Database session
room_id: Room ID
"""
room = db.query(IncidentRoom).filter(
IncidentRoom.room_id == room_id
).first()
if room:
room.last_activity_at = datetime.utcnow()
db.commit()
def permanent_delete_room(
self,
db: Session,
room_id: str
) -> Tuple[bool, Optional[str]]:
"""Permanently delete a room and all associated data (admin only)
This is an irreversible operation that:
1. Deletes all files from MinIO storage
2. Deletes all report documents from MinIO storage
3. Cascades delete to all related database records
Args:
db: Database session
room_id: Room ID to permanently delete
Returns:
Tuple of (success, error_message)
"""
# Late imports to avoid circular dependency
from app.modules.file_storage.models import RoomFile
from app.modules.report_generation.models import GeneratedReport
from app.modules.file_storage.services import minio_service
from app.core.config import get_settings
settings = get_settings()
# Check room exists
room = db.query(IncidentRoom).filter(
IncidentRoom.room_id == room_id
).first()
if not room:
return False, "Room not found"
try:
# Step 1: Delete room files from MinIO
room_files = db.query(RoomFile).filter(
RoomFile.room_id == room_id
).all()
for rf in room_files:
if rf.minio_object_path:
success = minio_service.delete_file(
rf.minio_bucket or settings.MINIO_BUCKET,
rf.minio_object_path
)
if not success:
logger.warning(
f"Failed to delete MinIO file: {rf.minio_object_path}"
)
# Step 2: Delete generated report documents from MinIO
reports = db.query(GeneratedReport).filter(
GeneratedReport.room_id == room_id
).all()
for report in reports:
if report.docx_storage_path:
success = minio_service.delete_file(
settings.MINIO_BUCKET,
report.docx_storage_path
)
if not success:
logger.warning(
f"Failed to delete report file: {report.docx_storage_path}"
)
# Step 3: Delete reports from database (before room delete due to relationship handling)
for report in reports:
db.delete(report)
# Step 4: Delete room from database (CASCADE handles other related tables)
db.delete(room)
db.commit()
logger.info(f"Permanently deleted room {room_id} and all associated data")
return True, None
except Exception as e:
db.rollback()
logger.error(f"Failed to permanently delete room {room_id}: {e}")
return False, str(e)
# Create singleton instance
room_service = RoomService()