Files
PROJECT-CONTORL/frontend/src/components/TaskDetailModal.tsx
beabigegg 3bdc6ff1c9 feat: implement 8 OpenSpec proposals for security, reliability, and UX improvements
## Security Enhancements (P0)
- Add input validation with max_length and numeric range constraints
- Implement WebSocket token authentication via first message
- Add path traversal prevention in file storage service

## Permission Enhancements (P0)
- Add project member management for cross-department access
- Implement is_department_manager flag for workload visibility

## Cycle Detection (P0)
- Add DFS-based cycle detection for task dependencies
- Add formula field circular reference detection
- Display user-friendly cycle path visualization

## Concurrency & Reliability (P1)
- Implement optimistic locking with version field (409 Conflict on mismatch)
- Add trigger retry mechanism with exponential backoff (1s, 2s, 4s)
- Implement cascade restore for soft-deleted tasks

## Rate Limiting (P1)
- Add tiered rate limits: standard (60/min), sensitive (20/min), heavy (5/min)
- Apply rate limits to tasks, reports, attachments, and comments

## Frontend Improvements (P1)
- Add responsive sidebar with hamburger menu for mobile
- Improve touch-friendly UI with proper tap target sizes
- Complete i18n translations for all components

## Backend Reliability (P2)
- Configure database connection pool (size=10, overflow=20)
- Add Redis fallback mechanism with message queue
- Add blocker check before task deletion

## API Enhancements (P3)
- Add standardized response wrapper utility
- Add /health/ready and /health/live endpoints
- Implement project templates with status/field copying

## Tests Added
- test_input_validation.py - Schema and path traversal tests
- test_concurrency_reliability.py - Optimistic locking and retry tests
- test_backend_reliability.py - Connection pool and Redis tests
- test_api_enhancements.py - Health check and template tests

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
2026-01-10 22:13:43 +08:00

849 lines
24 KiB
TypeScript

import { useState, useEffect, useCallback, useRef } from 'react'
import { useTranslation } from 'react-i18next'
import api from '../services/api'
import { Comments } from './Comments'
import { TaskAttachments } from './TaskAttachments'
import { SubtaskList } from './SubtaskList'
import { UserSelect } from './UserSelect'
import { UserSearchResult } from '../services/collaboration'
import { customFieldsApi, CustomField, CustomValueResponse } from '../services/customFields'
import { CustomFieldInput } from './CustomFieldInput'
import { SkeletonList } from './Skeleton'
interface Task {
id: string
project_id: string
title: string
description: string | null
priority: string
status_id: string | null
status_name: string | null
status_color: string | null
assignee_id: string | null
assignee_name: string | null
due_date: string | null
time_estimate: number | null
subtask_count: number
parent_task_id: string | null
custom_values?: CustomValueResponse[]
version?: number
}
interface TaskStatus {
id: string
name: string
color: string
is_done: boolean
}
interface TaskDetailModalProps {
task: Task
statuses: TaskStatus[]
isOpen: boolean
onClose: () => void
onUpdate: () => void
onSubtaskClick?: (subtaskId: string) => void
}
export function TaskDetailModal({
task,
statuses,
isOpen,
onClose,
onUpdate,
onSubtaskClick,
}: TaskDetailModalProps) {
const { t, i18n } = useTranslation('tasks')
const [isEditing, setIsEditing] = useState(false)
const [saving, setSaving] = useState(false)
const [conflictError, setConflictError] = useState<{
message: string
currentVersion: number
yourVersion: number
} | null>(null)
const [editForm, setEditForm] = useState({
title: task.title,
description: task.description || '',
priority: task.priority,
status_id: task.status_id || '',
assignee_id: task.assignee_id || '',
due_date: task.due_date ? task.due_date.split('T')[0] : '',
time_estimate: task.time_estimate || '',
})
const [, setSelectedAssignee] = useState<UserSearchResult | null>(
task.assignee_id && task.assignee_name
? { id: task.assignee_id, name: task.assignee_name, email: '' }
: null
)
// Custom fields state
const [customFields, setCustomFields] = useState<CustomField[]>([])
const [customValues, setCustomValues] = useState<CustomValueResponse[]>([])
const [editCustomValues, setEditCustomValues] = useState<Record<string, string | number | null>>({})
const [loadingCustomFields, setLoadingCustomFields] = useState(false)
const loadCustomFields = useCallback(async () => {
setLoadingCustomFields(true)
try {
const response = await customFieldsApi.getCustomFields(task.project_id)
setCustomFields(response.fields)
} catch (err) {
console.error('Failed to load custom fields:', err)
} finally {
setLoadingCustomFields(false)
}
}, [task.project_id])
// Load custom fields for the project
useEffect(() => {
if (task.project_id) {
loadCustomFields()
}
}, [task.project_id, loadCustomFields])
// Initialize custom values from task
useEffect(() => {
setCustomValues(task.custom_values || [])
// Build edit values map
const valuesMap: Record<string, string | number | null> = {}
if (task.custom_values) {
task.custom_values.forEach((cv) => {
valuesMap[cv.field_id] = cv.value
})
}
setEditCustomValues(valuesMap)
}, [task.custom_values])
// Reset form when task changes
useEffect(() => {
setEditForm({
title: task.title,
description: task.description || '',
priority: task.priority,
status_id: task.status_id || '',
assignee_id: task.assignee_id || '',
due_date: task.due_date ? task.due_date.split('T')[0] : '',
time_estimate: task.time_estimate || '',
})
setSelectedAssignee(
task.assignee_id && task.assignee_name
? { id: task.assignee_id, name: task.assignee_name, email: '' }
: null
)
setIsEditing(false)
}, [task])
// Reference to the modal overlay for focus management
const overlayRef = useRef<HTMLDivElement>(null)
// Handle Escape key to close modal
useEffect(() => {
const handleKeyDown = (e: KeyboardEvent) => {
if (e.key === 'Escape' && isOpen) {
onClose()
}
}
if (isOpen) {
document.addEventListener('keydown', handleKeyDown)
// Focus the overlay for keyboard accessibility
overlayRef.current?.focus()
}
return () => {
document.removeEventListener('keydown', handleKeyDown)
}
}, [isOpen, onClose])
if (!isOpen) return null
const handleSave = async () => {
setSaving(true)
setConflictError(null)
try {
const payload: Record<string, unknown> = {
title: editForm.title,
description: editForm.description || null,
priority: editForm.priority,
}
// Include version for optimistic locking
if (task.version) {
payload.version = task.version
}
// Always send status_id (null to clear, or the value)
payload.status_id = editForm.status_id || null
// Always send assignee_id (null to clear, or the value)
payload.assignee_id = editForm.assignee_id || null
if (editForm.due_date) {
// Convert date string to datetime format for Pydantic 2
payload.due_date = `${editForm.due_date}T00:00:00`
} else {
payload.due_date = null
}
if (editForm.time_estimate) {
payload.time_estimate = Number(editForm.time_estimate)
} else {
payload.time_estimate = null
}
// Include custom field values (only non-formula fields)
const customValuesPayload = Object.entries(editCustomValues)
.filter(([fieldId]) => {
const field = customFields.find((f) => f.id === fieldId)
return field && field.field_type !== 'formula'
})
.map(([fieldId, value]) => ({
field_id: fieldId,
value: value,
}))
if (customValuesPayload.length > 0) {
payload.custom_values = customValuesPayload
}
await api.patch(`/tasks/${task.id}`, payload)
setIsEditing(false)
onUpdate()
} catch (err: unknown) {
// Handle 409 Conflict - version mismatch
if (err && typeof err === 'object' && 'response' in err) {
const axiosError = err as { response?: { status?: number; data?: { detail?: { error?: string; message?: string; current_version?: number; your_version?: number } } } }
if (axiosError.response?.status === 409) {
const detail = axiosError.response?.data?.detail
if (detail?.error === 'conflict') {
setConflictError({
message: detail.message || t('conflict.message'),
currentVersion: detail.current_version || 0,
yourVersion: detail.your_version || 0,
})
return
}
}
}
console.error('Failed to update task:', err)
} finally {
setSaving(false)
}
}
const handleRefreshTask = () => {
setConflictError(null)
setIsEditing(false)
onUpdate()
}
const handleCustomFieldChange = (fieldId: string, value: string | number | null) => {
setEditCustomValues((prev) => ({
...prev,
[fieldId]: value,
}))
}
const handleAssigneeChange = (userId: string | null, user: UserSearchResult | null) => {
setEditForm({ ...editForm, assignee_id: userId || '' })
setSelectedAssignee(user)
}
const handleOverlayClick = (e: React.MouseEvent) => {
if (e.target === e.currentTarget) {
onClose()
}
}
const getPriorityColor = (priority: string): string => {
const colors: Record<string, string> = {
low: '#808080',
medium: '#0066cc',
high: '#ff9800',
urgent: '#f44336',
}
return colors[priority] || colors.medium
}
return (
<div
ref={overlayRef}
style={styles.overlay}
onClick={handleOverlayClick}
tabIndex={-1}
role="dialog"
aria-modal="true"
aria-labelledby="task-detail-title"
>
<div style={styles.modal}>
<div style={styles.header}>
<div style={styles.headerLeft}>
<div
style={{
...styles.priorityIndicator,
backgroundColor: getPriorityColor(task.priority),
}}
/>
{isEditing ? (
<input
type="text"
value={editForm.title}
onChange={(e) => setEditForm({ ...editForm, title: e.target.value })}
style={styles.titleInput}
autoFocus
/>
) : (
<h2 id="task-detail-title" style={styles.title}>{task.title}</h2>
)}
</div>
<div style={styles.headerActions}>
{!isEditing ? (
<button onClick={() => setIsEditing(true)} style={styles.editButton}>
{t('common:buttons.edit')}
</button>
) : (
<>
<button
onClick={() => setIsEditing(false)}
style={styles.cancelButton}
disabled={saving}
>
{t('common:buttons.cancel')}
</button>
<button
onClick={handleSave}
style={styles.saveButton}
disabled={saving || !editForm.title.trim()}
>
{saving ? t('common:labels.loading') : t('common:buttons.save')}
</button>
</>
)}
<button onClick={onClose} style={styles.closeButton} aria-label={t('common:buttons.close')}>
X
</button>
</div>
</div>
{/* Conflict Error Banner */}
{conflictError && (
<div style={styles.conflictBanner}>
<div style={styles.conflictContent}>
<div style={styles.conflictIcon}>!</div>
<div style={styles.conflictText}>
<div style={styles.conflictTitle}>{t('conflict.title')}</div>
<div style={styles.conflictMessage}>{t('conflict.message')}</div>
</div>
</div>
<button onClick={handleRefreshTask} style={styles.conflictRefreshButton}>
{t('common:buttons.refresh')}
</button>
</div>
)}
<div style={styles.content}>
<div style={styles.mainSection}>
{/* Description */}
<div style={styles.field}>
<label style={styles.fieldLabel}>{t('fields.description')}</label>
{isEditing ? (
<textarea
value={editForm.description}
onChange={(e) =>
setEditForm({ ...editForm, description: e.target.value })
}
style={styles.textarea}
placeholder={t('fields.descriptionPlaceholder')}
/>
) : (
<div style={styles.descriptionText}>
{task.description || t('common:labels.noData')}
</div>
)}
</div>
{/* Comments Section */}
<div style={styles.section}>
<Comments taskId={task.id} />
</div>
{/* Attachments Section */}
<div style={styles.section}>
<TaskAttachments taskId={task.id} />
</div>
{/* Subtasks Section - only allow adding subtasks if this is not already a subtask (depth limit = 2) */}
<div style={styles.section}>
<SubtaskList
taskId={task.id}
projectId={task.project_id}
onSubtaskClick={onSubtaskClick}
onSubtaskCreated={onUpdate}
canAddSubtask={!task.parent_task_id}
/>
</div>
</div>
<div style={styles.sidebar}>
{/* Status */}
<div style={styles.sidebarField}>
<label style={styles.sidebarLabel}>{t('fields.status')}</label>
{isEditing ? (
<select
value={editForm.status_id}
onChange={(e) =>
setEditForm({ ...editForm, status_id: e.target.value })
}
style={styles.select}
>
<option value="">{t('status.noStatus')}</option>
{statuses.map((status) => (
<option key={status.id} value={status.id}>
{status.name}
</option>
))}
</select>
) : (
<div
style={{
...styles.statusBadge,
backgroundColor: task.status_color || '#e0e0e0',
}}
>
{task.status_name || t('status.noStatus')}
</div>
)}
</div>
{/* Priority */}
<div style={styles.sidebarField}>
<label style={styles.sidebarLabel}>{t('fields.priority')}</label>
{isEditing ? (
<select
value={editForm.priority}
onChange={(e) =>
setEditForm({ ...editForm, priority: e.target.value })
}
style={styles.select}
>
<option value="low">{t('priority.low')}</option>
<option value="medium">{t('priority.medium')}</option>
<option value="high">{t('priority.high')}</option>
<option value="urgent">{t('priority.urgent')}</option>
</select>
) : (
<div
style={{
...styles.priorityBadge,
borderColor: getPriorityColor(task.priority),
color: getPriorityColor(task.priority),
}}
>
{t(`priority.${task.priority}`)}
</div>
)}
</div>
{/* Assignee */}
<div style={styles.sidebarField}>
<label style={styles.sidebarLabel}>{t('fields.assignee')}</label>
{isEditing ? (
<UserSelect
value={editForm.assignee_id || null}
valueName={task.assignee_name}
onChange={handleAssigneeChange}
placeholder={t('common:labels.selectAssignee')}
/>
) : (
<div style={styles.assigneeDisplay}>
{task.assignee_name || t('status.unassigned')}
</div>
)}
</div>
{/* Due Date */}
<div style={styles.sidebarField}>
<label style={styles.sidebarLabel}>{t('fields.dueDate')}</label>
{isEditing ? (
<input
type="date"
value={editForm.due_date}
onChange={(e) =>
setEditForm({ ...editForm, due_date: e.target.value })
}
style={styles.dateInput}
/>
) : (
<div style={styles.dueDateDisplay}>
{task.due_date
? new Date(task.due_date).toLocaleDateString(i18n.language, {
year: 'numeric',
month: 'short',
day: 'numeric',
})
: t('status.noDueDate')}
</div>
)}
</div>
{/* Time Estimate */}
<div style={styles.sidebarField}>
<label style={styles.sidebarLabel}>{t('fields.estimatedHours')}</label>
{isEditing ? (
<input
type="number"
min="0"
step="0.5"
value={editForm.time_estimate}
onChange={(e) =>
setEditForm({ ...editForm, time_estimate: e.target.value })
}
style={styles.numberInput}
placeholder="e.g., 2.5"
/>
) : (
<div style={styles.timeEstimateDisplay}>
{task.time_estimate ? t('fields.hours', { count: task.time_estimate }) : t('status.notEstimated')}
</div>
)}
</div>
{/* Subtasks Info */}
{task.subtask_count > 0 && (
<div style={styles.sidebarField}>
<label style={styles.sidebarLabel}>{t('subtasks.title')}</label>
<div style={styles.subtaskInfo}>{t('subtasks.count', { count: task.subtask_count })}</div>
</div>
)}
{/* Custom Fields Section */}
{customFields.length > 0 && (
<>
<div style={styles.customFieldsDivider} />
<div style={styles.customFieldsHeader}>{t('settings:customFields.title')}</div>
{loadingCustomFields ? (
<SkeletonList count={3} showAvatar={false} />
) : (
customFields.map((field) => {
// Get the value for this field
const valueResponse = customValues.find(
(v) => v.field_id === field.id
) || {
field_id: field.id,
field_name: field.name,
field_type: field.field_type,
value: editCustomValues[field.id] ?? null,
display_value: null,
}
// For editing mode, create a modified value response with edit values
const displayValue = isEditing
? {
...valueResponse,
value: editCustomValues[field.id] ?? valueResponse.value,
}
: valueResponse
return (
<div key={field.id} style={styles.sidebarField}>
<CustomFieldInput
field={field}
value={displayValue}
onChange={handleCustomFieldChange}
disabled={!isEditing || field.field_type === 'formula'}
showLabel={true}
/>
</div>
)
})
)}
</>
)}
</div>
</div>
</div>
</div>
)
}
const styles: Record<string, React.CSSProperties> = {
overlay: {
position: 'fixed',
top: 0,
left: 0,
right: 0,
bottom: 0,
backgroundColor: 'rgba(0, 0, 0, 0.5)',
display: 'flex',
justifyContent: 'center',
alignItems: 'center',
zIndex: 1000,
},
modal: {
backgroundColor: 'white',
borderRadius: '12px',
width: '90%',
maxWidth: '900px',
maxHeight: '90vh',
overflow: 'hidden',
display: 'flex',
flexDirection: 'column',
boxShadow: '0 8px 32px rgba(0, 0, 0, 0.2)',
},
header: {
display: 'flex',
justifyContent: 'space-between',
alignItems: 'center',
padding: '20px 24px',
borderBottom: '1px solid #eee',
},
headerLeft: {
display: 'flex',
alignItems: 'center',
gap: '12px',
flex: 1,
},
priorityIndicator: {
width: '6px',
height: '32px',
borderRadius: '3px',
},
title: {
margin: 0,
fontSize: '20px',
fontWeight: 600,
},
titleInput: {
fontSize: '20px',
fontWeight: 600,
border: '1px solid #ddd',
borderRadius: '4px',
padding: '8px 12px',
flex: 1,
marginRight: '12px',
},
headerActions: {
display: 'flex',
gap: '8px',
alignItems: 'center',
},
editButton: {
padding: '8px 16px',
backgroundColor: '#f5f5f5',
border: '1px solid #ddd',
borderRadius: '4px',
cursor: 'pointer',
fontSize: '14px',
},
saveButton: {
padding: '8px 16px',
backgroundColor: '#0066cc',
color: 'white',
border: 'none',
borderRadius: '4px',
cursor: 'pointer',
fontSize: '14px',
},
cancelButton: {
padding: '8px 16px',
backgroundColor: '#f5f5f5',
border: '1px solid #ddd',
borderRadius: '4px',
cursor: 'pointer',
fontSize: '14px',
},
closeButton: {
width: '32px',
height: '32px',
display: 'flex',
alignItems: 'center',
justifyContent: 'center',
backgroundColor: 'transparent',
border: 'none',
borderRadius: '4px',
cursor: 'pointer',
fontSize: '16px',
color: '#666',
marginLeft: '8px',
},
content: {
display: 'flex',
flex: 1,
overflow: 'hidden',
},
mainSection: {
flex: 1,
padding: '24px',
overflowY: 'auto',
borderRight: '1px solid #eee',
},
sidebar: {
width: '280px',
padding: '24px',
backgroundColor: '#fafafa',
overflowY: 'auto',
},
field: {
marginBottom: '24px',
},
fieldLabel: {
display: 'block',
fontSize: '12px',
fontWeight: 600,
color: '#666',
marginBottom: '8px',
textTransform: 'uppercase',
},
textarea: {
width: '100%',
minHeight: '100px',
padding: '12px',
border: '1px solid #ddd',
borderRadius: '4px',
fontSize: '14px',
resize: 'vertical',
boxSizing: 'border-box',
},
descriptionText: {
fontSize: '14px',
lineHeight: 1.6,
color: '#333',
whiteSpace: 'pre-wrap',
},
section: {
marginBottom: '24px',
},
sidebarField: {
marginBottom: '20px',
},
sidebarLabel: {
display: 'block',
fontSize: '11px',
fontWeight: 600,
color: '#888',
marginBottom: '6px',
textTransform: 'uppercase',
},
select: {
width: '100%',
padding: '10px',
border: '1px solid #ddd',
borderRadius: '4px',
fontSize: '14px',
boxSizing: 'border-box',
backgroundColor: 'white',
},
statusBadge: {
display: 'inline-block',
padding: '6px 12px',
borderRadius: '4px',
fontSize: '13px',
fontWeight: 500,
color: 'white',
},
priorityBadge: {
display: 'inline-block',
padding: '6px 12px',
border: '2px solid',
borderRadius: '4px',
fontSize: '13px',
fontWeight: 500,
},
assigneeDisplay: {
fontSize: '14px',
color: '#333',
},
dueDateDisplay: {
fontSize: '14px',
color: '#333',
},
timeEstimateDisplay: {
fontSize: '14px',
color: '#333',
},
subtaskInfo: {
fontSize: '14px',
color: '#666',
},
dateInput: {
width: '100%',
padding: '10px',
border: '1px solid #ddd',
borderRadius: '4px',
fontSize: '14px',
boxSizing: 'border-box',
},
numberInput: {
width: '100%',
padding: '10px',
border: '1px solid #ddd',
borderRadius: '4px',
fontSize: '14px',
boxSizing: 'border-box',
},
customFieldsDivider: {
height: '1px',
backgroundColor: '#ddd',
margin: '20px 0',
},
customFieldsHeader: {
fontSize: '12px',
fontWeight: 600,
color: '#666',
marginBottom: '16px',
textTransform: 'uppercase',
},
loadingText: {
fontSize: '13px',
color: '#888',
fontStyle: 'italic',
},
conflictBanner: {
display: 'flex',
alignItems: 'center',
justifyContent: 'space-between',
padding: '12px 24px',
backgroundColor: '#fff3cd',
borderBottom: '1px solid #ffc107',
},
conflictContent: {
display: 'flex',
alignItems: 'center',
gap: '12px',
},
conflictIcon: {
width: '24px',
height: '24px',
borderRadius: '50%',
backgroundColor: '#ff9800',
color: 'white',
display: 'flex',
alignItems: 'center',
justifyContent: 'center',
fontWeight: 'bold',
fontSize: '14px',
},
conflictText: {
flex: 1,
},
conflictTitle: {
fontWeight: 600,
fontSize: '14px',
color: '#856404',
},
conflictMessage: {
fontSize: '13px',
color: '#856404',
marginTop: '2px',
},
conflictRefreshButton: {
padding: '8px 16px',
backgroundColor: '#ff9800',
color: 'white',
border: 'none',
borderRadius: '4px',
cursor: 'pointer',
fontSize: '14px',
fontWeight: 500,
},
}
export default TaskDetailModal