3bdc6ff1c9
## Security Enhancements (P0) - Add input validation with max_length and numeric range constraints - Implement WebSocket token authentication via first message - Add path traversal prevention in file storage service ## Permission Enhancements (P0) - Add project member management for cross-department access - Implement is_department_manager flag for workload visibility ## Cycle Detection (P0) - Add DFS-based cycle detection for task dependencies - Add formula field circular reference detection - Display user-friendly cycle path visualization ## Concurrency & Reliability (P1) - Implement optimistic locking with version field (409 Conflict on mismatch) - Add trigger retry mechanism with exponential backoff (1s, 2s, 4s) - Implement cascade restore for soft-deleted tasks ## Rate Limiting (P1) - Add tiered rate limits: standard (60/min), sensitive (20/min), heavy (5/min) - Apply rate limits to tasks, reports, attachments, and comments ## Frontend Improvements (P1) - Add responsive sidebar with hamburger menu for mobile - Improve touch-friendly UI with proper tap target sizes - Complete i18n translations for all components ## Backend Reliability (P2) - Configure database connection pool (size=10, overflow=20) - Add Redis fallback mechanism with message queue - Add blocker check before task deletion ## API Enhancements (P3) - Add standardized response wrapper utility - Add /health/ready and /health/live endpoints - Implement project templates with status/field copying ## Tests Added - test_input_validation.py - Schema and path traversal tests - test_concurrency_reliability.py - Optimistic locking and retry tests - test_backend_reliability.py - Connection pool and Redis tests - test_api_enhancements.py - Health check and template tests Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
77 lines
3.4 KiB
Python
77 lines
3.4 KiB
Python
from sqlalchemy import Column, String, Text, Integer, Boolean, DateTime, Numeric, Enum, ForeignKey
|
|
from sqlalchemy.orm import relationship
|
|
from sqlalchemy.sql import func
|
|
from app.core.database import Base
|
|
import enum
|
|
|
|
|
|
class Priority(str, enum.Enum):
|
|
LOW = "low"
|
|
MEDIUM = "medium"
|
|
HIGH = "high"
|
|
URGENT = "urgent"
|
|
|
|
|
|
class Task(Base):
|
|
__tablename__ = "pjctrl_tasks"
|
|
|
|
id = Column(String(36), primary_key=True)
|
|
project_id = Column(String(36), ForeignKey("pjctrl_projects.id", ondelete="CASCADE"), nullable=False)
|
|
parent_task_id = Column(String(36), ForeignKey("pjctrl_tasks.id", ondelete="CASCADE"), nullable=True)
|
|
title = Column(String(500), nullable=False)
|
|
description = Column(Text, nullable=True)
|
|
assignee_id = Column(String(36), ForeignKey("pjctrl_users.id"), nullable=True)
|
|
status_id = Column(String(36), ForeignKey("pjctrl_task_statuses.id"), nullable=True)
|
|
priority = Column(
|
|
Enum("low", "medium", "high", "urgent", name="priority_enum"),
|
|
default="medium",
|
|
nullable=False
|
|
)
|
|
original_estimate = Column(Numeric(8, 2), nullable=True)
|
|
time_spent = Column(Numeric(8, 2), default=0, nullable=False)
|
|
blocker_flag = Column(Boolean, default=False, nullable=False)
|
|
start_date = Column(DateTime, nullable=True)
|
|
due_date = Column(DateTime, nullable=True)
|
|
position = Column(Integer, default=0, nullable=False)
|
|
created_by = Column(String(36), ForeignKey("pjctrl_users.id"), nullable=False)
|
|
created_at = Column(DateTime, server_default=func.now(), nullable=False)
|
|
updated_at = Column(DateTime, server_default=func.now(), onupdate=func.now(), nullable=False)
|
|
|
|
# Optimistic locking field
|
|
version = Column(Integer, default=1, nullable=False)
|
|
|
|
# Soft delete fields
|
|
is_deleted = Column(Boolean, default=False, nullable=False, index=True)
|
|
deleted_at = Column(DateTime, nullable=True)
|
|
deleted_by = Column(String(36), ForeignKey("pjctrl_users.id"), nullable=True)
|
|
|
|
# Relationships
|
|
project = relationship("Project", back_populates="tasks")
|
|
parent_task = relationship("Task", remote_side=[id], back_populates="subtasks")
|
|
subtasks = relationship("Task", back_populates="parent_task", cascade="all, delete-orphan")
|
|
assignee = relationship("User", foreign_keys=[assignee_id], back_populates="assigned_tasks")
|
|
creator = relationship("User", foreign_keys=[created_by], back_populates="created_tasks")
|
|
deleter = relationship("User", foreign_keys=[deleted_by])
|
|
status = relationship("TaskStatus", back_populates="tasks")
|
|
|
|
# Collaboration relationships
|
|
comments = relationship("Comment", back_populates="task", cascade="all, delete-orphan")
|
|
blockers = relationship("Blocker", back_populates="task", cascade="all, delete-orphan")
|
|
attachments = relationship("Attachment", back_populates="task", cascade="all, delete-orphan")
|
|
trigger_logs = relationship("TriggerLog", back_populates="task")
|
|
custom_values = relationship("TaskCustomValue", back_populates="task", cascade="all, delete-orphan")
|
|
|
|
# Dependency relationships (for Gantt view)
|
|
predecessors = relationship(
|
|
"TaskDependency",
|
|
foreign_keys="TaskDependency.successor_id",
|
|
back_populates="successor",
|
|
cascade="all, delete-orphan"
|
|
)
|
|
successors = relationship(
|
|
"TaskDependency",
|
|
foreign_keys="TaskDependency.predecessor_id",
|
|
back_populates="predecessor",
|
|
cascade="all, delete-orphan"
|
|
)
|