## Security Enhancements (P0) - Add input validation with max_length and numeric range constraints - Implement WebSocket token authentication via first message - Add path traversal prevention in file storage service ## Permission Enhancements (P0) - Add project member management for cross-department access - Implement is_department_manager flag for workload visibility ## Cycle Detection (P0) - Add DFS-based cycle detection for task dependencies - Add formula field circular reference detection - Display user-friendly cycle path visualization ## Concurrency & Reliability (P1) - Implement optimistic locking with version field (409 Conflict on mismatch) - Add trigger retry mechanism with exponential backoff (1s, 2s, 4s) - Implement cascade restore for soft-deleted tasks ## Rate Limiting (P1) - Add tiered rate limits: standard (60/min), sensitive (20/min), heavy (5/min) - Apply rate limits to tasks, reports, attachments, and comments ## Frontend Improvements (P1) - Add responsive sidebar with hamburger menu for mobile - Improve touch-friendly UI with proper tap target sizes - Complete i18n translations for all components ## Backend Reliability (P2) - Configure database connection pool (size=10, overflow=20) - Add Redis fallback mechanism with message queue - Add blocker check before task deletion ## API Enhancements (P3) - Add standardized response wrapper utility - Add /health/ready and /health/live endpoints - Implement project templates with status/field copying ## Tests Added - test_input_validation.py - Schema and path traversal tests - test_concurrency_reliability.py - Optimistic locking and retry tests - test_backend_reliability.py - Connection pool and Redis tests - test_api_enhancements.py - Health check and template tests Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
64 lines
1.7 KiB
Python
64 lines
1.7 KiB
Python
from pydantic import BaseModel, Field, field_validator
|
|
from typing import Optional, List
|
|
from datetime import datetime
|
|
from decimal import Decimal
|
|
|
|
|
|
class UserBase(BaseModel):
|
|
email: str = Field(..., max_length=255)
|
|
name: str = Field(..., min_length=1, max_length=200)
|
|
department_id: Optional[str] = None
|
|
role_id: Optional[str] = None
|
|
skills: Optional[List[str]] = None
|
|
capacity: Optional[Decimal] = Field(Decimal("40.00"), ge=0, le=168)
|
|
|
|
|
|
class UserCreate(UserBase):
|
|
pass
|
|
|
|
|
|
class UserUpdate(BaseModel):
|
|
name: Optional[str] = Field(None, min_length=1, max_length=200)
|
|
department_id: Optional[str] = None
|
|
role_id: Optional[str] = None
|
|
skills: Optional[List[str]] = None
|
|
capacity: Optional[Decimal] = Field(None, ge=0, le=168)
|
|
is_active: Optional[bool] = None
|
|
|
|
|
|
class UserResponse(UserBase):
|
|
id: str
|
|
is_active: bool
|
|
is_system_admin: bool
|
|
created_at: datetime
|
|
updated_at: datetime
|
|
|
|
class Config:
|
|
from_attributes = True
|
|
|
|
|
|
class UserInDB(UserResponse):
|
|
pass
|
|
|
|
|
|
class CapacityUpdate(BaseModel):
|
|
"""Schema for updating user's weekly capacity hours."""
|
|
capacity_hours: Decimal
|
|
|
|
@field_validator("capacity_hours")
|
|
@classmethod
|
|
def validate_capacity_hours(cls, v: Decimal) -> Decimal:
|
|
"""Validate capacity hours is within valid range (0-168)."""
|
|
if v < 0:
|
|
raise ValueError("Capacity hours must be non-negative")
|
|
if v > 168:
|
|
raise ValueError("Capacity hours cannot exceed 168 (hours in a week)")
|
|
return v
|
|
|
|
class Config:
|
|
json_schema_extra = {
|
|
"example": {
|
|
"capacity_hours": 40.00
|
|
}
|
|
}
|