This commit implements comprehensive external Azure AD authentication with complete task management, file download, and admin monitoring systems. ## Core Features Implemented (80% Complete) ### 1. Token Auto-Refresh Mechanism ✅ - Backend: POST /api/v2/auth/refresh endpoint - Frontend: Auto-refresh 5 minutes before expiration - Auto-retry on 401 errors with seamless token refresh ### 2. File Download System ✅ - Three format support: JSON / Markdown / PDF - Endpoints: GET /api/v2/tasks/{id}/download/{format} - File access control with ownership validation - Frontend download buttons in TaskHistoryPage ### 3. Complete Task Management ✅ Backend Endpoints: - POST /api/v2/tasks/{id}/start - Start task - POST /api/v2/tasks/{id}/cancel - Cancel task - POST /api/v2/tasks/{id}/retry - Retry failed task - GET /api/v2/tasks - List with filters (status, filename, date range) - GET /api/v2/tasks/stats - User statistics Frontend Features: - Status-based action buttons (Start/Cancel/Retry) - Advanced search and filtering (status, filename, date range) - Pagination and sorting - Task statistics dashboard (5 stat cards) ### 4. Admin Monitoring System ✅ (Backend) Admin APIs: - GET /api/v2/admin/stats - System statistics - GET /api/v2/admin/users - User list with stats - GET /api/v2/admin/users/top - User leaderboard - GET /api/v2/admin/audit-logs - Audit log query system - GET /api/v2/admin/audit-logs/user/{id}/summary Admin Features: - Email-based admin check (ymirliu@panjit.com.tw) - Comprehensive system metrics (users, tasks, sessions, activity) - Audit logging service for security tracking ### 5. User Isolation & Security ✅ - Row-level security on all task queries - File access control with ownership validation - Strict user_id filtering on all operations - Session validation and expiry checking - Admin privilege verification ## New Files Created Backend: - backend/app/models/user_v2.py - User model for external auth - backend/app/models/task.py - Task model with user isolation - backend/app/models/session.py - Session management - backend/app/models/audit_log.py - Audit log model - backend/app/services/external_auth_service.py - External API client - backend/app/services/task_service.py - Task CRUD with isolation - backend/app/services/file_access_service.py - File access control - backend/app/services/admin_service.py - Admin operations - backend/app/services/audit_service.py - Audit logging - backend/app/routers/auth_v2.py - V2 auth endpoints - backend/app/routers/tasks.py - Task management endpoints - backend/app/routers/admin.py - Admin endpoints - backend/alembic/versions/5e75a59fb763_*.py - DB migration Frontend: - frontend/src/services/apiV2.ts - Complete V2 API client - frontend/src/types/apiV2.ts - V2 type definitions - frontend/src/pages/TaskHistoryPage.tsx - Task history UI Modified Files: - backend/app/core/deps.py - Added get_current_admin_user_v2 - backend/app/main.py - Registered admin router - frontend/src/pages/LoginPage.tsx - V2 login integration - frontend/src/components/Layout.tsx - User display and logout - frontend/src/App.tsx - Added /tasks route ## Documentation - openspec/changes/.../PROGRESS_UPDATE.md - Detailed progress report ## Pending Items (20%) 1. Database migration execution for audit_logs table 2. Frontend admin dashboard page 3. Frontend audit log viewer ## Testing Status - Manual testing: ✅ Authentication flow verified - Unit tests: ⏳ Pending - Integration tests: ⏳ Pending ## Security Enhancements - ✅ User isolation (row-level security) - ✅ File access control - ✅ Token expiry validation - ✅ Admin privilege verification - ✅ Audit logging infrastructure - ⏳ Token encryption (noted, low priority) - ⏳ Rate limiting (noted, low priority) 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
78 lines
2.1 KiB
Python
78 lines
2.1 KiB
Python
"""
|
|
Tool_OCR - File Access Control Service
|
|
Validates user permissions for file access
|
|
"""
|
|
|
|
import os
|
|
import logging
|
|
from typing import Optional
|
|
from sqlalchemy.orm import Session
|
|
|
|
from app.models.task import Task
|
|
|
|
logger = logging.getLogger(__name__)
|
|
|
|
|
|
class FileAccessService:
|
|
"""Service for validating file access permissions"""
|
|
|
|
def validate_file_access(
|
|
self,
|
|
db: Session,
|
|
user_id: int,
|
|
task_id: str,
|
|
file_path: Optional[str]
|
|
) -> tuple[bool, Optional[str]]:
|
|
"""
|
|
Validate that user has access to the file
|
|
|
|
Args:
|
|
db: Database session
|
|
user_id: User ID requesting access
|
|
task_id: Task ID associated with the file
|
|
file_path: Path to the file
|
|
|
|
Returns:
|
|
Tuple of (is_valid, error_message)
|
|
"""
|
|
# Check if file path is provided
|
|
if not file_path:
|
|
return False, "File not available"
|
|
|
|
# Get task and verify ownership
|
|
task = db.query(Task).filter(
|
|
Task.task_id == task_id,
|
|
Task.user_id == user_id
|
|
).first()
|
|
|
|
if not task:
|
|
logger.warning(
|
|
f"Unauthorized file access attempt: "
|
|
f"user {user_id} tried to access task {task_id}"
|
|
)
|
|
return False, "Task not found or access denied"
|
|
|
|
# Check if task is completed
|
|
if task.status.value != "completed":
|
|
return False, "Task not completed yet"
|
|
|
|
# Check if file exists
|
|
if not os.path.exists(file_path):
|
|
logger.error(f"File not found: {file_path}")
|
|
return False, "File not found on server"
|
|
|
|
# Verify file is readable
|
|
if not os.access(file_path, os.R_OK):
|
|
logger.error(f"File not readable: {file_path}")
|
|
return False, "File not accessible"
|
|
|
|
logger.info(
|
|
f"File access granted: user {user_id} accessing {file_path} "
|
|
f"for task {task_id}"
|
|
)
|
|
return True, None
|
|
|
|
|
|
# Singleton instance
|
|
file_access_service = FileAccessService()
|