egg/OCR
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: correct Phase 3 implementation and remove invalid OCR track alignment

Browse Source 
Address Phase 3 accuracy issues identified in review:

**Issue 1: Invalid OCR Track Alignment Code**
- Removed alignment extraction from region style (lines 1179-1185)
- Removed alignment-based positioning logic (lines 1215-1240)
- Problem: OCR track has no StyleInfo (extracted from images without style data)
- Result: Alignment code was non-functional, always defaulted to left
- Solution: Simplified to explicit left-aligned rendering for OCR track

**Issue 2: Misleading Task Completion Markers**
- Updated 5.1: Clarified both tracks support line-by-line rendering
  - Direct: _draw_text_element_direct (lines 1549-1693)
  - OCR: draw_text_region (lines 1113-1270, simplified)
- Updated 5.2: Marked as "Direct track only"
  - spacing_before: Applied (adjusts Y position)
  - spacing_after: Implicit in bbox-based layout (recorded for analysis)
  - indent/first_line_indent: Direct track only
  - OCR: No paragraph handling
- Updated 5.3: Marked as "Direct track only"
  - Direct: Supports left/right/center/justify alignment
  - OCR: Left-aligned only (no StyleInfo available)

**Technical Clarifications**
- spacing_after cannot be "applied" in bbox-based layout
- It is already reflected in element positions (bbox spacing)
- bbox_bottom_margin shows the implicit spacing_after value
- OCR track uses simplified rendering (design decision per design.md)

**Modified Files**
- backend/app/services/pdf_generator_service.py
  - Removed lines 1179-1185: Invalid alignment extraction
  - Removed lines 1215-1240: Invalid alignment logic
  - Added comments clarifying OCR track limitations
- openspec/changes/pdf-layout-restoration/tasks.md
  - Added "(Direct track only)" markers to 5.2 and 5.3
  - Changed 5.3.5 from "Add OCR track alignment support" to "OCR track: left-aligned only"
  - Added 5.2.6 to note OCR has no paragraph handling

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
This commit is contained in:
egg
2025-11-24 08:58:55 +08:00
parent 8ba61f51b3
commit e1e97c54cf
2 changed files with 16 additions and 48 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
openspec/changes/pdf-layout-restoration/tasks.md
View File

@@ -77,23 +77,25 @@
## Phase 3: Advanced Layout (P2 - Week 2)
### 5. Enhanced Text Rendering
- [x] 5.1 Implement line-by-line rendering
- [x] 5.1 Implement line-by-line rendering (both tracks)
- [x] 5.1.1 Split text content by newlines (text.split('\n'))
- [x] 5.1.2 Calculate line height from font size (font_size * 1.2)
- [x] 5.1.3 Render each line with proper spacing (line_y = pdf_y - i * line_height)
- [x] 5.1.4 Add OCR track support in draw_text_region (lines 1199-1254)
- [x] 5.2 Add paragraph handling
- [x] 5.1.4 Direct track: _draw_text_element_direct (lines 1549-1693)
- [x] 5.1.5 OCR track: draw_text_region (lines 1113-1270, simplified)
- [x] 5.2 Add paragraph handling (Direct track only)
- [x] 5.2.1 Detect paragraph boundaries (via element.type PARAGRAPH)
- [x] 5.2.2 Apply paragraph spacing (spacing_before/spacing_after from metadata)
- [x] 5.2.3 Handle indentation (indent/first_line_indent from metadata)
- [x] 5.2.4 Record spacing_after with actual text height analysis (lines 1680-1689)
- [x] 5.2.5 Calculate bbox_bottom_margin to show implicit spacing
- [x] 5.3 Implement text alignment
- [x] 5.2.2 Apply spacing_before from metadata (line 1576, adjusts Y position)
- [x] 5.2.3 Handle indentation (indent/first_line_indent from metadata, lines 1564-1565)
- [x] 5.2.4 Record spacing_after for analysis (lines 1680-1689)
- [x] 5.2.5 Note: spacing_after is implicit in bbox-based layout (bbox_bottom_margin)
- [x] 5.2.6 OCR track: no paragraph handling (simple left-aligned rendering)
- [x] 5.3 Implement text alignment (Direct track only)
- [x] 5.3.1 Support left/right/center/justify (from StyleInfo.alignment)
- [x] 5.3.2 Calculate positioning based on alignment (line_x calculation)
- [x] 5.3.3 Apply to each text block (per-line alignment in _draw_text_element_direct)
- [x] 5.3.4 Justify alignment with word spacing distribution
- [x] 5.3.5 Add OCR track alignment support (extract from style, lines 1179-1247)
- [x] 5.3.5 OCR track: left-aligned only (no StyleInfo available)
### 6. List Formatting
- [ ] 6.1 Detect list elements